[tools] master update

Dr. Paul Dale pauli at openssl.org
Fri Oct 4 05:44:52 UTC 2019


The branch master has been updated
       via  e3587da72ead14568de95a8fb1cf8198f71e4200 (commit)
      from  571c0af75c9dc840757b5478c83a14d49af84bee (commit)


- Log -----------------------------------------------------------------
commit e3587da72ead14568de95a8fb1cf8198f71e4200
Author: Dr. Matthias St. Pierre <Matthias.St.Pierre at ncp-e.com>
Date:   Thu Oct 3 23:34:14 2019 +0200

    cherry-checker: fix: don't choke on semicolons in the commit message title
    
    The semicolon is used as separator for the git output, so make sure
    to stop the line.split() after the third separator, otherwise the
    subject line might get split further.
    
    (see openssl/openssl at bd01733fdd Fix comment; unchecked->checked)
    
    Reviewed-by: Paul Dale <paul.dale at oracle.com>
    (Merged from https://github.com/openssl/openssl/pull/43)

-----------------------------------------------------------------------

Summary of changes:
 review-tools/cherry-checker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/review-tools/cherry-checker b/review-tools/cherry-checker
index dbdbd06..318eee6 100755
--- a/review-tools/cherry-checker
+++ b/review-tools/cherry-checker
@@ -88,7 +88,7 @@ def pick_cherries(left, right, all = False):
 
     for line in subprocess.check_output(git_command).decode().splitlines():
 
-        timestamp, branch, commit, subject = line.split(";")
+        timestamp, branch, commit, subject = line.split(";", maxsplit=3)
 
         if branch == '=' and not all:
             continue


More information about the openssl-commits mailing list