<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<tt>I would guess that no one has ever set EVP_CHECK_DES_KEY during
the 11 years the code has been around (since commit
216659eb87485402a8e861a6de77233d1f5d7425), so maybe that code
should just be removed. Sorry I didn't mention that in the ticket;
I was in the middle of something else at the time but wanted to
note the issue while it was in front of me.<br>
<br>
-Ben<br>
</tt><br>
<div class="moz-cite-prefix">On 10/11/2015 04:36 PM, Ben Laurie
wrote:<br>
</div>
<blockquote
cite="mid:CAG5KPzyQGntn1G+EmyqQ8K7L01FwD0BA-8trRgX94YC0455qig@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<div dir="ltr">How did that ever compile? Is EVP_CHECK_DES_KEY
ever set?</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Sat, 10 Oct 2015 at 16:50 Dr. Stephen Henson
<<a moz-do-not-send="true" href="mailto:steve@openssl.org">steve@openssl.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">The branch
OpenSSL_1_0_2-stable has been updated<br>
via 6868346585f38066de4610b516346a18a98a8427 (commit)<br>
from 985abd1fd8aa24ef1bbf6adcf1923d07b35fa246 (commit)<br>
<br>
<br>
- Log
-----------------------------------------------------------------<br>
commit 6868346585f38066de4610b516346a18a98a8427<br>
Author: Dr. Stephen Henson <<a moz-do-not-send="true"
href="mailto:steve@openssl.org" target="_blank">steve@openssl.org</a>><br>
Date: Sun Oct 11 00:06:56 2015 +0100<br>
<br>
Typo.<br>
<br>
PR#4079<br>
<br>
Reviewed-by: Tim Hudson <<a moz-do-not-send="true"
href="mailto:tjh@openssl.org" target="_blank">tjh@openssl.org</a>><br>
(cherry picked from commit
c69ce9351336f5b4a8b33890756b3fd185528210)<br>
<br>
-----------------------------------------------------------------------<br>
<br>
Summary of changes:<br>
crypto/evp/e_des3.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/crypto/evp/e_des3.c b/crypto/evp/e_des3.c<br>
index 96f272e..bf6c1d2 100644<br>
--- a/crypto/evp/e_des3.c<br>
+++ b/crypto/evp/e_des3.c<br>
@@ -289,7 +289,7 @@ static int des_ede_init_key(EVP_CIPHER_CTX
*ctx, const unsigned char *key,<br>
# endif<br>
# ifdef EVP_CHECK_DES_KEY<br>
if (DES_set_key_checked(&deskey[0], &dat->ks1)<br>
- ! !DES_set_key_checked(&deskey[1],
&dat->ks2))<br>
+ || DES_set_key_checked(&deskey[1],
&dat->ks2))<br>
return 0;<br>
# else<br>
DES_set_key_unchecked(&deskey[0], &dat->ks1);<br>
_____<br>
openssl-commits mailing list<br>
To unsubscribe: <a moz-do-not-send="true"
href="https://urldefense.proofpoint.com/v2/url?u=https-3A__mta.openssl.org_mailman_listinfo_openssl-2Dcommits&d=BQMFaQ&c=96ZbZZcaMF4w0F4jpN6LZg&r=sssDLkeEEBWNIXmTsdpw8TZ3tAJx-Job4p1unc7rOhM&m=2bMQx1g4zFgKwqTuiHku5h_nSCjV33uYrlBYVEfat3k&s=Kd8SsSaL4KsJEDB4ecZGzDIfxVxNbuxJYFJM8q6nBHY&e="
rel="noreferrer" target="_blank">https://mta.openssl.org/mailman/listinfo/openssl-commits</a><br>
</blockquote>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_____
openssl-commits mailing list
To unsubscribe: <a class="moz-txt-link-freetext" href="https://mta.openssl.org/mailman/listinfo/openssl-commits">https://mta.openssl.org/mailman/listinfo/openssl-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>