<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri","sans-serif";}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">I was just moving an OpenSSL Engine over to use the restructured ECDH and ECDSA methods on the master branch where structures ecdsa_method (ECDSA_METHOD)and ecdh_method (ECDH_METHOD) have been amalgamated into ec_key_method_st (EC_KEY_METHOD).<o:p></o:p></p>
<p class="MsoNormal">Traditionally there has been what could be considered a ‘bug’ where the ecdh_method and ecdsa_method structures are defined within private headers ech_locl.h and ecs_locl.h respectively instead of the public headers.<o:p></o:p></p>
<p class="MsoNormal">This forces an OpenSSL engine that wants to provide its own implementations to include the local header files, and hardcode an include path to them, as they don’t exist in the public headers directory.<o:p></o:p></p>
<p class="MsoNormal">Following Steve’s ec_key_method_st changes the data structure we need to now use for our own implementations remains only defined in ec_lcl.h and not part of the public interface.<o:p></o:p></p>
<p class="MsoNormal">For mainline OpenSSL 1.1.0 there has been a focus on making many of the data structures opaque which shouldn’t have been part of the public interface.<o:p></o:p></p>
<p class="MsoNormal">I was wondering whether it was a conscious decision on Steve or the teams part to keep the ec_key_method_st only defined in the local header file, because of trying to keep data structures opaque, or whether it was just not considered as
part of the tidyup?<o:p></o:p></p>
<p class="MsoNormal">I was interested to know if it was something I could change, and raise a pull request for, or whether I was wasting my time as it is intentional?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoPlainText">-- <o:p></o:p></p>
<p class="MsoPlainText">Steve Linsell Intel Shannon DCG/CID Software Development Team<o:p></o:p></p>
<p class="MsoPlainText"><a href="mailto:Stevenx.Linsell@intel.com">Stevenx.Linsell@intel.com</a>
<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p>--------------------------------------------------------------<br>
Intel Research and Development Ireland Limited<br>
Registered in Ireland<br>
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare<br>
Registered Number: 308263</p>
<p>This e-mail and any attachments may contain confidential material for the
sole use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.</p>
<p></p>
</body>
</html>