<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class="">I agree that there is a possible flaw in the workflow. What’s saved us so far is that new contributors don’t generally include the "CLA: trivial" line or put it in the GitHub text.</div><div class=""><br class=""></div><div class="">Could we have a “trivial” tag that is added whenever the "CLA: trivial" line is present? Better would be to add it only if the submitter doesn’t have a CLA on file but either works.</div><div class=""><br class=""></div><div class=""><div class=""><div class=""><br class=""></div><div class="">Pauli<br class=""><div class="">
<div dir="auto" style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;">-- <br class="">Dr Paul Dale | Distinguished Architect | Cryptographic Foundations <br class="">Phone +61 7 3031 7217<br class="">Oracle Australia</div><div style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><br class=""></div><br class="Apple-interchange-newline"></div><br class="Apple-interchange-newline">
</div>
<div><br class=""><blockquote type="cite" class=""><div class="">On 12 Dec 2019, at 7:20 pm, Matt Caswell <<a href="mailto:matt@openssl.org" class="">matt@openssl.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">I notice that PR 10594 (Add support for otherName:NAIRealm in output)<br class="">got merged yesterday:<br class=""><a href="https://github.com/openssl/openssl/pull/10594" class="">https://github.com/openssl/openssl/pull/10594</a><br class=""><br class="">The commit description contained "CLA: trivial" and so the "hold: cla<br class="">required" label was not automatically applied to the PR. But the<br class="">discussion in the PR suggested a CLA should be submitted. But it got<br class="">merged anyway! Fortunately the CLA had already been processed - just not<br class="">noted in the PR. So, in this case, it makes no difference.<br class=""><br class="">I think this points to a possible flaw in our workflow for dealing with<br class="">trivial changes. Because the "CLA: trivial" header suppresses the "hold:<br class="">cla required" label and the git hooks don't complain when commits get<br class="">pushed with the "CLA: trivial" header and no CLA on file, it seems<br class="">possible to me that we could push commit all the way through the process<br class="">without the reviewers even realising that the author is claiming<br class="">triviality on the commit.<br class=""><br class="">Not sure what the solution to that is.<br class=""><br class="">Matt<br class=""></div></div></blockquote></div><br class=""></div></div></div></body></html>