<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">A better example of this problem: #10607. Both Paul and I approved it yesterday and I merged it today without noticing until too late that it was tagged “CLA: trivial” :(<div class="">I’ve not reverted it at this point but will if necessary.<br class=""><div class=""><br class=""></div><div class="">Let’s get the label in.</div><div class=""><br class=""></div><div class=""><br class=""><div class="">
<div dir="auto" style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div>Pauli<br class="">-- <br class="">Dr Paul Dale | Distinguished Architect | Cryptographic Foundations <br class="">Phone +61 7 3031 7217<br class="">Oracle Australia</div><div><br class=""></div></div><br class="Apple-interchange-newline"><br class="Apple-interchange-newline">
</div>
<div><br class=""><blockquote type="cite" class=""><div class="">On 13 Dec 2019, at 11:02 am, Richard Levitte <<a href="mailto:levitte@openssl.org" class="">levitte@openssl.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">On Thu, 12 Dec 2019 22:31:10 +0100,<br class="">Dr Paul Dale wrote:<br class=""><blockquote type="cite" class=""><br class="">A red blocker along the lines of: “Triviality Unconfirmed”. One of<br class="">the reviewers needs to remove this before the PR can be merged.<br class=""><br class="">It’s in our face, it prevent accidental merges and its low overhead.<br class=""></blockquote><br class="">I still think simply adding the label should be sufficient. I dunno<br class="">about you, but I look at labels all the time, for all sorts of<br class="">reasons, and one saying [cla: trivial] would certainly attract my<br class="">attention.<br class=""><br class="">Let's make it bright red-orange, that'll catch anyone's eye (even mine)<br class=""><br class="">Also, removing that label will rapidly be annoying as soon as someone<br class="">closes and re-opens a PR... or whatever other action that triggers<br class="">the "pull_request" event (and there's a lot that does that... our<br class="">script is being kept busy!).<br class=""><br class="">Cheers,<br class="">Richard<br class=""><br class="">-- <br class="">Richard Levitte <a href="mailto:levitte@openssl.org" class="">levitte@openssl.org</a><br class="">OpenSSL Project <a href="http://www.openssl.org/~levitte/" class="">http://www.openssl.org/~levitte/</a><br class=""></div></div></blockquote></div><br class=""></div></div></body></html>