<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Please don’t automatically drop the "appoval: done" label after a comment. I feel that is not uncommon for comments to be added that in no way invalidate the approval.<div class=""><br class=""></div><div class="">I agree with not switching to “ready to merge” if there are comments — manual intervention in this case is required to judge the relevancy.</div><div class=""><br class=""></div><div class="">Agreed also over the “urgent” label.</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Pauli<br class=""><div class="">
<div dir="auto" style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;">-- <br class="">Dr Paul Dale | Distinguished Architect | Cryptographic Foundations <br class="">Phone +61 7 3031 7217<br class="">Oracle Australia</div><div style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><br class=""></div><br class="Apple-interchange-newline"></div><br class="Apple-interchange-newline">
</div>
<div><br class=""><blockquote type="cite" class=""><div class="">On 9 Feb 2020, at 1:56 am, Mark J Cox <<a href="mailto:mark@openssl.org" class="">mark@openssl.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">I've currently got a cron job running every hour that looks at open PR<br class="">requests against github openssl repo and does various actions. So if<br class="">you were wondering why I was altering labels and making comments at<br class="">4am, now you know. No doubt we'll use some tool user for this in the<br class="">future.<br class=""><br class="">So right now here's what it does:<br class=""><br class="">Every hour it looks at open PRs that are labelled "approval: done".<br class="">If 24 hours has elapsed since that label was assigned and if there<br class="">have been no comments made to the PR since the label was assigned then<br class="">it is automatically moved to "approval: ready to merge" with a comment<br class="">added to trigger notifications. So if you want to stop something<br class="">going to "ready to merge" just add any comment to the PR.<br class=""><br class="">I'm thinking of using this script also to 1) collect interesting stats<br class="">and 2) do some other actions. So if there's some automation you'd<br class="">like to see just add an enhancement issue against the openssl/tools<br class="">repo.<br class=""><br class="">1 Matt already asked for committer notification trigger for anything<br class="">labelled Urgent.<br class=""><br class="">2 If there were comments made after "approval: done" then I think we<br class="">really ought to drop the "approval: done" label as the comments likely<br class="">invalidated the approval. So I'll likely add that next week (if<br class="">"approval: done" label and has comments since that label then remove<br class="">the label and add a comment 'please review if this is really approval:<br class="">done'. If the approval: done label gets set again then after 24 hours<br class="">the existing automation will trigger. #10786 is a good example of<br class="">this.<br class=""><br class="">Mark<br class=""></div></div></blockquote></div><br class=""></div></body></html>