<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">An alternative would be to only run a cut down selection of tests with msan.<div class=""><br class=""></div><div class=""><br class=""></div><div class="">Pauli<br class=""><div class="">
<div dir="auto" style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;">-- <br class="">Dr Paul Dale | Distinguished Architect | Cryptographic Foundations <br class="">Phone +61 7 3031 7217<br class="">Oracle Australia</div><div style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><br class=""></div><br class="Apple-interchange-newline"></div><br class="Apple-interchange-newline">
</div>
<div><br class=""><blockquote type="cite" class=""><div class="">On 14 Feb 2020, at 11:00 pm, Matt Caswell <<a href="mailto:matt@openssl.org" class="">matt@openssl.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><br class=""><br class="">On 14/02/2020 12:23, Nicola Tuveri wrote:<br class=""><blockquote type="cite" class="">If ASAN is too slow to run in the CI should we restore the previous<br class="">homemade checks for memory leaks as an alternative to be run in regular<br class="">CI runs and leave ASAN builds to run-checker on the master branch only? <br class=""></blockquote><br class="">To be clear the build that is timing out uses *msan* not *asan*.<br class=""><br class="">As I understand it msan detects unitialised reads. whereas asan detects<br class="">memory corruption, buffer overflows, use-after-free bugs, and memory leaks.<br class=""><br class="">The previous "home-made" checks only detected memory leaks, so it is not<br class="">comparable with the functionality offered by msan.<br class=""><br class="">The msan documentation<br class="">(<a href="https://urldefense.com/v3/__https://clang.llvm.org/docs/MemorySanitizer.html__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6xiEvnC0$" class="">https://urldefense.com/v3/__https://clang.llvm.org/docs/MemorySanitizer.html__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6xiEvnC0$</a> ) suggests that a slow<br class="">down of 3x is typical.<br class=""><br class="">It seems reasonable to me to disable msan checks in Travis entirely, and<br class="">have them only in run-checker.<br class=""><br class=""><blockquote type="cite" class=""><br class="">Here is another idea that would be interesting if we restore the<br class="">previous checks:<br class="">I don't know what kind of options github offers on this, but would it be<br class="">possible to run triggered CI on something that is not Travis and does<br class="">not timeout and still have the results in the PR?<br class=""></blockquote><br class="">I am sure there are hooks to do this. Richard has been talking for quite<br class="">a while about setting up a buildbot infrastructure. If that could be<br class="">integrated into github that would be really neat.<br class=""><br class="">Matt<br class=""><br class=""><br class=""><blockquote type="cite" class="">If something like that would be possible we could move the ASAN builds<br class="">to extended_tests, rely on the previous memleak detection for the<br class="">regular CI runs, and then trigger with a script or Github Action the<br class="">extended_tests when the approval:done label is added. <br class=""><br class="">That way, by the time something is ready to be merged we should have a<br class="">full picture! <br class=""><br class=""><br class="">Nicola<br class=""><br class="">On Wed, Feb 5, 2020, 10:25 Matt Caswell <<a href="mailto:matt@openssl.org" class="">matt@openssl.org</a><br class=""><<a href="mailto:matt@openssl.org" class="">mailto:matt@openssl.org</a>>> wrote:<br class=""><br class=""> Since we fixed the Travis builds 4 out of the 8 builds on master that<br class=""> have taken place have errored due to a timeout.<br class=""><br class=""> The msan build is consistently taking a *very* long time to run. If it<br class=""> gets to 50 minutes then Travis cuts it off and the build fails.<br class=""><br class=""> Should we disable the msan build?<br class=""><br class=""> Matt<br class=""><br class=""><br class=""> -------- Forwarded Message --------<br class=""> Subject: Errored: openssl/openssl#31939 (master - 34b1676)<br class=""> Date: Wed, 05 Feb 2020 00:02:01 +0000<br class=""> From: Travis CI <<a href="mailto:builds@travis-ci.org" class="">builds@travis-ci.org</a> <<a href="mailto:builds@travis-ci.org" class="">mailto:builds@travis-ci.org</a>>><br class=""> To: <a href="mailto:openssl-commits@openssl.org" class="">openssl-commits@openssl.org</a> <<a href="mailto:openssl-commits@openssl.org" class="">mailto:openssl-commits@openssl.org</a>><br class=""><br class=""><br class=""><br class=""> openssl<br class=""><br class=""> /<br class=""><br class=""> openssl<br class=""><br class=""> <<a href="https://urldefense.com/v3/__https://travis-ci.org/openssl/openssl?utm_medium=notification&utm_source=email__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6bPlKFFo$" class="">https://urldefense.com/v3/__https://travis-ci.org/openssl/openssl?utm_medium=notification&utm_source=email__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6bPlKFFo$</a> ><br class=""><br class=""><br class=""> branch iconmaster <<a href="https://urldefense.com/v3/__https://github.com/openssl/openssl/tree/master__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6tYedpt0$" class="">https://urldefense.com/v3/__https://github.com/openssl/openssl/tree/master__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6tYedpt0$</a> ><br class=""><br class=""> build has errored<br class=""> Build #31939 has errored<br class=""> <<a href="https://urldefense.com/v3/__https://travis-ci.org/openssl/openssl/builds/646181069?utm_medium=notification&utm_source=email__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6dntSzqk$" class="">https://urldefense.com/v3/__https://travis-ci.org/openssl/openssl/builds/646181069?utm_medium=notification&utm_source=email__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6dntSzqk$</a> ><br class=""> arrow to build time<br class=""> clock icon50 mins and 3 secs<br class=""><br class=""> Pauli avatarPauli<br class=""><br class=""> 34b1676 CHANGESET →<br class=""> <<a href="https://urldefense.com/v3/__https://github.com/openssl/openssl/compare/e3b1ccad694a...34b167625af5__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6KOlK4nk$" class="">https://urldefense.com/v3/__https://github.com/openssl/openssl/compare/e3b1ccad694a...34b167625af5__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6KOlK4nk$</a> ><br class=""><br class=""> Make minimum size for secure memory a size_t.<br class=""><br class=""> The minimum size argument to CRYPTO_secure_malloc_init() was an int but<br class=""> ought<br class=""> to be a size_t since it is a size.<br class=""><br class=""> From an API perspective, this is a change. However, the minimum size is<br class=""> verified as being a positive power of two and it will typically be a<br class=""> small<br class=""> constant.<br class=""><br class=""> Reviewed-by: David von Oheimb <<a href="mailto:david.von.oheimb@siemens.com" class="">david.von.oheimb@siemens.com</a><br class=""> <<a href="mailto:david.von.oheimb@siemens.com" class="">mailto:david.von.oheimb@siemens.com</a>>><br class=""> (Merged from #11003)<br class=""><br class=""> Want to know about upcoming build environment updates?<br class=""><br class=""> Would you like to stay up-to-date with the upcoming Travis CI build<br class=""> environment updates? We set up a mailing list for you!<br class=""><br class=""> SIGN UP HERE <<a href="https://urldefense.com/v3/__http://eepurl.com/9OCsP__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6Ph3gEAw$" class="">https://urldefense.com/v3/__http://eepurl.com/9OCsP__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6Ph3gEAw$</a> ><br class=""><br class=""> book icon<br class=""><br class=""> Documentation <<a href="https://urldefense.com/v3/__https://docs.travis-ci.com/__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6v9qS6uM$" class="">https://urldefense.com/v3/__https://docs.travis-ci.com/__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6v9qS6uM$</a> > about Travis CI<br class=""><br class=""> Have any questions? We're here to help.<br class=""> <<a href="mailto:support@travis-ci.com" class="">mailto:support@travis-ci.com</a> <<a href="mailto:support@travis-ci.com" class="">mailto:support@travis-ci.com</a>>><br class=""> Unsubscribe<br class=""> <<a href="https://urldefense.com/v3/__https://travis-ci.org/account/preferences/unsubscribe?repository=5849220&utm_medium=notification&utm_source=email__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6oQu1lKw$" class="">https://urldefense.com/v3/__https://travis-ci.org/account/preferences/unsubscribe?repository=5849220&utm_medium=notification&utm_source=email__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6oQu1lKw$</a> ><br class=""> from build emails from the openssl/openssl repository.<br class=""> To unsubscribe from *all* build emails, please update your settings<br class=""> <<a href="https://urldefense.com/v3/__https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6D5G5fTA$" class="">https://urldefense.com/v3/__https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6D5G5fTA$</a> >.<br class=""><br class=""> black and white travis ci logo <<a href="https://urldefense.com/v3/__https://travis-ci.com__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6xy6N1qM$" class="">https://urldefense.com/v3/__https://travis-ci.com__;!!GqivPVa7Brio!JwD52xjNRP5yVXTD3K12Mn17HiC2xHM_O6YzFE7G32G1BYh-NID9mIM6xy6N1qM$</a> ><br class=""><br class=""> Travis CI GmbH, Rigaer Str. 8, 10427 Berlin, Germany | GF/CEO: Randy<br class=""> Jacops | Contact: <a href="mailto:contact@travis-ci.com" class="">contact@travis-ci.com</a><br class=""> <<a href="mailto:contact@travis-ci.com" class="">mailto:contact@travis-ci.com</a>> <<a href="mailto:contact@travis-ci.com" class="">mailto:contact@travis-ci.com</a><br class=""> <<a href="mailto:contact@travis-ci.com" class="">mailto:contact@travis-ci.com</a>>> |<br class=""> Amtsgericht Charlottenburg, Berlin, HRB 140133 B | Umsatzsteuer-ID gemäß<br class=""> §27 a Umsatzsteuergesetz: DE282002648<br class=""><br class=""></blockquote></div></div></blockquote></div><br class=""></div></body></html>