[openssl-users] PerlASM for x64

[Jakob Bohm]

On 24/12/2018 19:08, Richard Levitte wrote:
> In message <3fc4d543-d71a-8c22-566a-d902c4f7da03 at gmail.com> on Mon, 24 Dec 2018 13:17:51 +0100, Gisle Vanem <gisle.vanem at gmail.com> said:
>
>> Richard Levitte wrote:
>>
>>>> I experimented some more. I figured the "auto" does not work.
>>>> But this works:
>>>>     perl crypto\aes\asm\aesni-x86_64.pl nasm > tmp-file.s
>>>>     diff tmp-file.s crypto\aes\aesni-x86_64.asm
>>>>
>>>> No diffs.
>>>>
>>>> Why does the the generation of .asm-files be so damn hard to
>>>> figure out? Some cmd-line help to show what "auto" does would
>>>> be nice.
>>> The "auto" flavor takes note of the output file extension.  .asm vs .s
>>> in this case.
>> Thank, but it was a typo in my 1st email. The correct command was
>> with a redirect:
>>    set ASM=nasm
>>    f:\util\StrawberryPerl\perl\bin\perl crypto\aes\asm\aesni-x86_64.pl
>>    auto > tmp-file.s
> That isn't a correct use of the script.  All of the assembler perl
> scripts expect the output file as last argument, and the x86_64 ones
> do look at the output file and determines that if the extension is
> '.asm', nasm assembler is expected, otherwise you will get gas
> assembler.  So if you redirect, the result is, mildly put, undefined.
>
> Thank you, though...  it is time the assembler stuff gets documented,
> and I think I'm in a fairly good position to do so.  I will not
> promise that it will happen fast, but it is in my backlog.
As a trivial (and easily audited first patch) perhaps make the
common code error out with a usage message to STDERR if the
command line makes no sense (no output file, wrong argument
count, auto with unrecognized file extension).  Ideally this
would be in the common perl module(s), not in individual
assembler files.

Remember that keeping every patch easily audited by the wider
community is essential to the trustworthiness of OpenSSL, the
great reformatting a while back was a major mistake in this
regard.

Enjoy

Jakob
-- 
Jakob Bohm, CIO, Partner, WiseMo A/S.  https://www.wisemo.com
Transformervej 29, 2860 Søborg, Denmark.  Direct +45 31 13 16 10
This public discussion message is non-binding and may contain errors.
WiseMo - Remote Service Management for PCs, Phones and Embedded