run-checker NO DGRAM and test cases

[Michael Richardson]

Tomas Mraz <tomas at openssl.org> wrote:
    >> I figured out that this means that ./Configure should have "no-dgram"
    >> appended to it.  That seems to result in OPENSSL_NO_DGRAM being
    >> defined.
    >>
    >> My test case naturally does not compile for that.
    >>
    >> Should my test case just be surrounded by #ifndef OPENSSL_NO_DGRAM
    >> from top to bottom (leaving...?), or is there something more
    >> sophisticated that should go into build.info in order to skip the test
    >> in that configuration?

    > Please look at the other examples in tests/build.info - there are
    > things disabled for no-sock and other stuff. But you'll also need to
    > skip the test in the perl test recipe.

I thought it was shell script, but now that I look more at it, I guess it is
a custom DSL.

  IF[{- !$disabled{dgram} -}]
        PROGRAMS{noinst}=bio_write_test
  ENDIF
  SOURCE[bio_write_test]=bio_write_test.c
  INCLUDE[bio_write_test]=../include ../apps/include
  DEPEND[bio_write_test]=../libcrypto libtestutil.a

Should I repeat the test for the two programs, or should I group into a
single IF for both programs?

i.e.
  IF[{- !$disabled{dgram} -}]
        PROGRAMS{noinst}=bio_write_test bio_read_test
  ENDIF

I guess maybe the tests could be named with dgram in the file name, since
that's all they do.  Should the test *ALSO* ifdef itself out if
OPENSSL_NO_DGRAM is defined?

It already does:

#if defined(_WIN32)
int setup_tests(void)
{
    return 1;
}
...


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 658 bytes
Desc: not available
URL: <https://mta.openssl.org/pipermail/openssl-users/attachments/20220317/5dc6d4f3/attachment.sig>