<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Bell MT";
panose-1:2 2 5 3 6 3 5 2 3 3;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:9.0pt;font-family:"Arial",sans-serif;color:#7F7F7F">Honeywell Internal</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">I think I have an answer for why this commit needed to be reverted:<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:11.0pt;color:#7030A0">Author: Dr. Stephen Henson <steve@openssl.org><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:11.0pt;color:#7030A0">Author date: 2 years ago (12/20/2015 10:18:43 AM)<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:11.0pt;color:#7030A0">Commit date: 2 years ago (12/20/2015 11:27:03 AM)<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:11.0pt;color:#7030A0">Commit hash: 6656ba7152dfe4bba865e327dd362ea08544aa80<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:11.0pt;color:#7030A0">Children: 1c7de36f62<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:11.0pt;color:#7030A0">Parent(s): 17592f323a<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:11.0pt;color:#7030A0"><o:p> </o:p></span></p>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:11.0pt;color:#7030A0">Don't check RSA_FLAG_SIGN_VER.<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:11.0pt;color:#7030A0"><o:p> </o:p></span></p>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:11.0pt;color:#7030A0">Reviewed-by: Richard Levitte <levitte@openssl.org><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">The change made in that commit was to simply remove the attempt to check for the RSA_FLAG_SIGN_VER flag. But that’s not what is wrong with this code that required changing.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">The change should be to add “meth” prior to flags:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">@@ -84,7 +89,7 @@ int RSA_sign(int type, const unsigned char *m, unsigned int m_len,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> return 0;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> }<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">#endif<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">- if ((rsa->flags & RSA_FLAG_SIGN_VER) && rsa->meth->rsa_sign) {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">+ if ((rsa-><span style="background:yellow;mso-highlight:yellow">meth-></span>flags & RSA_FLAG_SIGN_VER) && rsa->meth->rsa_sign) {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> return rsa->meth->rsa_sign(type, m, m_len, sigret, siglen, rsa);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> }<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> /* Special case: SSL signature, just check the length */<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">@@ -293,7 +298,7 @@ int RSA_verify(int dtype, const unsigned char *m, unsigned int m_len,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> const unsigned char *sigbuf, unsigned int siglen, RSA *rsa)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">{<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">- if ((rsa->flags & RSA_FLAG_SIGN_VER) && rsa->meth->rsa_verify) {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">+ if ((rsa-><span style="background:yellow;mso-highlight:yellow">meth-></span>flags & RSA_FLAG_SIGN_VER) && rsa->meth->rsa_verify) {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> return rsa->meth->rsa_verify(dtype, m, m_len, sigbuf, siglen, rsa);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> }<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">--<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:gray">-Ike-</span></b><b><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:navy"><o:p></o:p></span></b></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:navy"> John Eichenberger<o:p></o:p></span></b></p>
<p class="MsoNormal"><b><i><span style="font-family:"Arial",sans-serif;color:navy">Intermec</span></i></b><b><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:navy">
</span></b><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:navy">by<b>
</b></span><b><span style="font-family:"Bell MT",serif;color:red">Honeywell</span></b><span style="font-size:11.0pt"><br>
</span><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:navy">Principal Engineer: Sustaining Engineering<b><o:p></o:p></b></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:gray">425.921.4507</span><span style="font-size:11.0pt"><o:p></o:p></span></p>
</div>
</div>
</body>
</html>