[openssl-commits] [openssl] master update

[Dr. Stephen Henson]

The branch master has been updated
       via  9c7a780bbebc1b6d87dc38a6aa3339033911a8bb (commit)
      from  259c360d0b4faad28c89c97352291219903ee3c5 (commit)


- Log -----------------------------------------------------------------
commit 9c7a780bbebc1b6d87dc38a6aa3339033911a8bb
Author: Dr. Stephen Henson <steve at openssl.org>
Date:   Sun Feb 8 13:14:05 2015 +0000

    Fix memory leak reporting.
    
    Free up bio_err after memory leak data has been printed to it.
    
    In int_free_ex_data if ex_data is NULL there is nothing to free up
    so return immediately and don't reallocate it.
    Reviewed-by: Tim Hudson <tjh at openssl.org>

-----------------------------------------------------------------------

Summary of changes:
 apps/openssl.c   |    8 ++++----
 crypto/ex_data.c |    2 ++
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/apps/openssl.c b/apps/openssl.c
index 50c8275..e070a44 100644
--- a/apps/openssl.c
+++ b/apps/openssl.c
@@ -423,10 +423,6 @@ int main(int Argc, char *ARGV[])
     if (arg.data != NULL)
         OPENSSL_free(arg.data);
 
-    if (bio_err != NULL) {
-        BIO_free(bio_err);
-        bio_err = NULL;
-    }
 #if defined( OPENSSL_SYS_VMS) && (__INITIAL_POINTER_SIZE == 64)
     /* Free any duplicate Argv[] storage. */
     if (free_Argv) {
@@ -435,6 +431,10 @@ int main(int Argc, char *ARGV[])
 #endif
     apps_shutdown();
     CRYPTO_mem_leaks(bio_err);
+    if (bio_err != NULL) {
+        BIO_free(bio_err);
+        bio_err = NULL;
+    }
 
     OPENSSL_EXIT(ret);
 }
diff --git a/crypto/ex_data.c b/crypto/ex_data.c
index 4caddce..d55985b 100644
--- a/crypto/ex_data.c
+++ b/crypto/ex_data.c
@@ -500,6 +500,8 @@ static void int_free_ex_data(int class_index, void *obj, CRYPTO_EX_DATA *ad)
     EX_CLASS_ITEM *item;
     void *ptr;
     CRYPTO_EX_DATA_FUNCS **storage = NULL;
+    if (ex_data == NULL)
+        return;
     if ((item = def_get_class(class_index)) == NULL)
         return;
     CRYPTO_r_lock(CRYPTO_LOCK_EX_DATA);