[openssl-commits] [openssl] master update
Matt Caswell
matt at openssl.org
Fri Feb 27 22:55:45 UTC 2015
The branch master has been updated
via af674d4e20a82c2a98767b837072d7093c70b1cf (commit)
from eadf70d2c885e3e4e943091eabfec1e73d4f3883 (commit)
- Log -----------------------------------------------------------------
commit af674d4e20a82c2a98767b837072d7093c70b1cf
Author: Matt Caswell <matt at openssl.org>
Date: Fri Feb 27 16:52:07 2015 +0000
Fix d2i_SSL_SESSION for DTLS1_BAD_VER
Some Cisco appliances use a pre-standard version number for DTLS. We support
this as DTLS1_BAD_VER within the code.
This change fixes d2i_SSL_SESSION for that DTLS version.
Based on an original patch by David Woodhouse <dwmw2 at infradead.org>
RT#3704
Reviewed-by: Tim Hudson <tjh at openssl.org>
-----------------------------------------------------------------------
Summary of changes:
ssl/dtls1.h | 1 +
ssl/ssl_asn1.c | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/ssl/dtls1.h b/ssl/dtls1.h
index ff406d8..542ae04 100644
--- a/ssl/dtls1.h
+++ b/ssl/dtls1.h
@@ -86,6 +86,7 @@ extern "C" {
# define DTLS1_VERSION 0xFEFF
# define DTLS1_2_VERSION 0xFEFD
# define DTLS_MAX_VERSION DTLS1_2_VERSION
+# define DTLS1_VERSION_MAJOR 0xFE
# define DTLS1_BAD_VER 0x0100
diff --git a/ssl/ssl_asn1.c b/ssl/ssl_asn1.c
index 63fe17f..dd02b41 100644
--- a/ssl/ssl_asn1.c
+++ b/ssl/ssl_asn1.c
@@ -410,7 +410,9 @@ SSL_SESSION *d2i_SSL_SESSION(SSL_SESSION **a, const unsigned char **pp,
os.data = NULL;
os.length = 0;
M_ASN1_D2I_get_x(ASN1_OCTET_STRING, osp, d2i_ASN1_OCTET_STRING);
- if ((ssl_version >> 8) >= SSL3_VERSION_MAJOR) {
+ if ((ssl_version >> 8) == SSL3_VERSION_MAJOR
+ || (ssl_version >> 8) == DTLS1_VERSION_MAJOR
+ || ssl_version == DTLS1_BAD_VER) {
if (os.length != 2) {
c.error = SSL_R_CIPHER_CODE_WRONG_LENGTH;
c.line = __LINE__;
More information about the openssl-commits
mailing list