[openssl-commits] [openssl] master update

Emilia Kasper emilia at openssl.org
Fri Feb 19 15:45:01 UTC 2016


The branch master has been updated
       via  f0496ad71fbacccf5a95f40d31d251bc8cf9dcfb (commit)
      from  eaa7e483c509d46f455a9deb148bfaf34a8fcbe3 (commit)


- Log -----------------------------------------------------------------
commit f0496ad71fbacccf5a95f40d31d251bc8cf9dcfb
Author: Emilia Kasper <emilia at openssl.org>
Date:   Fri Feb 19 16:23:08 2016 +0100

    getaddrinfo: zero the hints structure
    
    This silences the memory sanitizer. All fields were already correctly
    initialized but the struct padding wasn't, causing an uninitialized read
    warning.
    
    Reviewed-by: Tim Hudson <tjh at openssl.org>

-----------------------------------------------------------------------

Summary of changes:
 crypto/bio/b_addr.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/crypto/bio/b_addr.c b/crypto/bio/b_addr.c
index a46cf93..6125e86 100644
--- a/crypto/bio/b_addr.c
+++ b/crypto/bio/b_addr.c
@@ -681,18 +681,13 @@ int BIO_lookup(const char *host, const char *service,
         int gai_ret = 0;
 #ifdef AI_PASSIVE
         struct addrinfo hints;
+        memset(&hints, 0, sizeof hints);
 
-        hints.ai_flags = 0;
 # ifdef AI_ADDRCONFIG
         hints.ai_flags = AI_ADDRCONFIG;
 # endif
         hints.ai_family = family;
         hints.ai_socktype = socktype;
-        hints.ai_protocol = 0;
-        hints.ai_addrlen = 0;
-        hints.ai_addr = NULL;
-        hints.ai_canonname = NULL;
-        hints.ai_next = NULL;
 
         if (lookup_type == BIO_LOOKUP_SERVER)
             hints.ai_flags |= AI_PASSIVE;


More information about the openssl-commits mailing list