[openssl-commits] Passed: openssl/openssl#4099 (master - fcb318c)

Travis CI builds at travis-ci.org
Fri May 20 23:14:34 UTC 2016

Build Update for openssl/openssl

Build: #4099
Status: Passed

Duration: 29 minutes and 5 seconds
Commit: fcb318c (master)
Author: Matt Caswell
Message: Fix Windows 64 bit crashes

The function InitOnceExceuteOnce is the best way to support the
implementation of CRYPTO_THREAD_run_once() on Windows. Unfortunately
WinXP doesn't have it. To get around that we had two different
implementations: one for WinXP and one for later versions. Which one was
used was based on the value of _WIN32_WINNT.

This approach was starting to cause problems though because other parts of
OpenSSL assume _WIN32_WINNT is going to be 0x0501 and crashes were
occurring dependant on include file ordering. In addition a conditional
based on _WIN32_WINNT had made its way into a public header file through
commit 5c4328f. This is problematic because the value of this macro can
vary between OpenSSL build time and application build time.

The simplest solution to this mess is just to always use the WinXP version
of CRYPTO_THREAD_run_once(). Its perhaps slightly sub-optimal but probably
not noticably.

GitHub Issue #1086

Reviewed-by: Richard Levitte <levitte at openssl.org>

View the changeset: https://github.com/openssl/openssl/compare/739a1eb1961c...fcb318c64b8c

View the full build log and details: https://travis-ci.org/openssl/openssl/builds/131822947


You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mta.openssl.org/pipermail/openssl-commits/attachments/20160520/5714b07f/attachment.html>

More information about the openssl-commits mailing list