[openssl-commits] Passed: openssl/openssl#6195 (OpenSSL_1_0_2-stable - 4badd2b)

[Travis CI]

Build Update for openssl/openssl
-------------------------------------

Build: #6195
Status: Passed

Duration: 1 hour, 1 minute, and 40 seconds
Commit: 4badd2b (OpenSSL_1_0_2-stable)
Author: David Woodhouse
Message: Call ENGINE_init() before trying to use keys from engine

Things like 'openssl s_client' only ever worked with keys from an engine
which provided a default generic method for some key type — because it
called ENGINE_set_default() and that ended up being an implicit
initialisation and functional refcount.

But an engine which doesn't provide generic methods doesn't get
initialised, and then when you try to use it you get an error:

cannot load client certificate private key file from engine
140688147056384:error:26096075:engine routines:ENGINE_load_private_key:not initialised:crypto/engine/eng_pkey.c:66:
unable to load client certificate private key file

cf. https://github.com/OpenSC/libp11/issues/107 (in which we discover
that engine_pkcs11 *used* to provide generic methods that OpenSSL would
try to use for ephemeral DH keys when negotiating ECDHE cipher suites in
TLS, and that didn't work out very well.)

Reviewed-by: Richard Levitte <levitte at openssl.org>
Reviewed-by: Rich Salz <rsalz at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1640)

View the changeset: https://github.com/openssl/openssl/compare/9702bf5fa269...4badd2b3c29c

View the full build log and details: https://travis-ci.org/openssl/openssl/builds/163449098

--

You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mta.openssl.org/pipermail/openssl-commits/attachments/20160928/d751a3ac/attachment-0001.html>