[openssl-commits] [openssl] master update

Kurt Roeckx kurt at openssl.org
Mon Dec 25 12:30:22 UTC 2017

The branch master has been updated
       via  b12169eeafcd7660dce76cc290e379040a638fde (commit)
      from  4dfe4310c31c4483705991d9a798ce9be1ed1c68 (commit)

- Log -----------------------------------------------------------------
commit b12169eeafcd7660dce76cc290e379040a638fde
Author: Kurt Roeckx <kurt at roeckx.be>
Date:   Sat Dec 23 23:32:11 2017 +0100

    Fix comment about undefined behavior of constant_time_msb
    This comment was correct for the original commit introducing this
    function (5a3d21c0585064292bde5cd34089e120487ab687), but was fixed
    in commit d2fa182988afa33d9e950358de406cc9fb36d000 (and
    Reviewed-by: Ben Kaduk <kaduk at mit.edu>
    GH: #4975


Summary of changes:
 include/internal/constant_time_locl.h | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/include/internal/constant_time_locl.h b/include/internal/constant_time_locl.h
index 8b714fb..c60e59c 100644
--- a/include/internal/constant_time_locl.h
+++ b/include/internal/constant_time_locl.h
@@ -31,12 +31,7 @@ extern "C" {
  *      c = constant_time_select(lt, a, b);
- * Returns the given value with the MSB copied to all the other
- * bits. Uses the fact that arithmetic shift shifts-in the sign bit.
- * However, this is not ensured by the C standard so you may need to
- * replace this with something else on odd CPUs.
- */
+/* Returns the given value with the MSB copied to all the other bits. */
 static ossl_inline unsigned int constant_time_msb(unsigned int a);
 /* Convenience method for uint64_t. */
 static ossl_inline uint64_t constant_time_msb_64(uint64_t a);

More information about the openssl-commits mailing list