[openssl-commits] [openssl] master update

kaduk at mit.edu kaduk at mit.edu
Tue Jun 27 15:50:41 UTC 2017


The branch master has been updated
       via  c91ec013654e97ca1754db26bd2da62c8bbf7b47 (commit)
      from  0ffdaebf9a327f3b356df1cf72d74dd15ead7d13 (commit)


- Log -----------------------------------------------------------------
commit c91ec013654e97ca1754db26bd2da62c8bbf7b47
Author: Benjamin Kaduk <bkaduk at akamai.com>
Date:   Mon Jun 26 12:05:09 2017 -0500

    Fix return-value checks in OCSP_resp_get1_id()
    
    Commit db17e43d882ecde217e1dce4a2b8c76c3ed134bf added the function
    but would improperly report success if the underlying dup operation
    failed.
    
    Reviewed-by: Matt Caswell <matt at openssl.org>
    (Merged from https://github.com/openssl/openssl/pull/3775)

-----------------------------------------------------------------------

Summary of changes:
 crypto/ocsp/ocsp_cl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/ocsp/ocsp_cl.c b/crypto/ocsp/ocsp_cl.c
index 118b66a..f6101e1 100644
--- a/crypto/ocsp/ocsp_cl.c
+++ b/crypto/ocsp/ocsp_cl.c
@@ -230,7 +230,7 @@ int OCSP_resp_get1_id(const OCSP_BASICRESP *bs,
     } else {
         return 0;
     }
-    if (pname == NULL && pid == NULL)
+    if (*pname == NULL && *pid == NULL)
         return 0;
     return 1;
 }


More information about the openssl-commits mailing list