[openssl-commits] Still Failing: openssl/openssl#11188 (master - 0e83981)

[Travis CI]

Build Update for openssl/openssl
-------------------------------------

Build: #11188
Status: Still Failing

Duration: 18 minutes and 48 seconds
Commit: 0e83981 (master)
Author: Diego Santa Cruz
Message: Fix srp app missing NULL termination with password callback

The password_callback() function does not necessarily NULL terminate
the password buffer, the caller must use the returned length but the
srp app uses this function as if it was doing NULL termination.

This made the -passin and -passout options of "openssl srp"
fail inexpicably and randomly or even crash.

Fixed by enlarging the buffer by one, so that the maximum password length
remains unchanged, and adding NULL termination upon return.

[Rearrange code for coding style compliance in process.]

Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Andy Polyakov <appro at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/3475)

View the changeset: https://github.com/openssl/openssl/compare/48b5352212d8...0e83981d61fc

View the full build log and details: https://travis-ci.org/openssl/openssl/builds/234731984?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mta.openssl.org/pipermail/openssl-commits/attachments/20170522/1400f3be/attachment.html>