[openssl-commits] [openssl] OpenSSL_1_0_2-stable update

bernd.edlinger at hotmail.de bernd.edlinger at hotmail.de
Fri Nov 3 15:20:50 UTC 2017


The branch OpenSSL_1_0_2-stable has been updated
       via  950d49d43900e67a1f9d02bc1a053a9fdc5c4257 (commit)
      from  200de404214ed045df66e371b1d0a60992ee33d0 (commit)


- Log -----------------------------------------------------------------
commit 950d49d43900e67a1f9d02bc1a053a9fdc5c4257
Author: Pavel Kopyl <p.kopyl at samsung.com>
Date:   Fri Oct 27 16:13:11 2017 +0300

    Add error handling in dsa_main and ASN1_i2d_bio.
    
    CLA: trivial
    
    Reviewed-by: Kurt Roeckx <kurt at roeckx.be>
    Reviewed-by: Bernd Edlinger <bernd.edlinger at hotmail.de>
    (Merged from https://github.com/openssl/openssl/pull/4600)
    
    (cherry picked from commit a6f622bc99ffdc7b34199babb9d200b24a7a6431)

-----------------------------------------------------------------------

Summary of changes:
 apps/dsa.c             | 3 +++
 crypto/asn1/a_i2d_fp.c | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/apps/dsa.c b/apps/dsa.c
index 4ed21d8..82a870e 100644
--- a/apps/dsa.c
+++ b/apps/dsa.c
@@ -327,6 +327,9 @@ int MAIN(int argc, char **argv)
     } else if (outformat == FORMAT_MSBLOB || outformat == FORMAT_PVK) {
         EVP_PKEY *pk;
         pk = EVP_PKEY_new();
+        if (pk == NULL)
+           goto end;
+
         EVP_PKEY_set1_DSA(pk, dsa);
         if (outformat == FORMAT_PVK)
             i = i2b_PVK_bio(out, pk, pvk_encr, 0, passout);
diff --git a/crypto/asn1/a_i2d_fp.c b/crypto/asn1/a_i2d_fp.c
index 0f56cd4..2e85e04 100644
--- a/crypto/asn1/a_i2d_fp.c
+++ b/crypto/asn1/a_i2d_fp.c
@@ -87,6 +87,9 @@ int ASN1_i2d_bio(i2d_of_void *i2d, BIO *out, unsigned char *x)
     int i, j = 0, n, ret = 1;
 
     n = i2d(x, NULL);
+    if (n <= 0)
+        return 0;
+
     b = (char *)OPENSSL_malloc(n);
     if (b == NULL) {
         ASN1err(ASN1_F_ASN1_I2D_BIO, ERR_R_MALLOC_FAILURE);


More information about the openssl-commits mailing list