[openssl-commits] Errored: openssl/openssl#16216 (master - 5d67110)

Travis CI builds at travis-ci.org
Fri Feb 9 16:05:27 UTC 2018

Build Update for openssl/openssl

Build: #16216
Status: Errored

Duration: 29 minutes and 41 seconds
Commit: 5d67110 (master)
Author: Matt Caswell
Message: Don't calculate the Finished MAC twice

In <= TLSv1.2 a Finished message always comes immediately after a CCS
except in the case of NPN where there is an additional message between
the CCS and Finished. Historically we always calculated the Finished MAC
when we processed the CCS. However to deal with NPN we also calculated it
when we receive the Finished message. Really this should only have been
done if we hand negotiated NPN.

This simplifies the code to only calculate the MAC when we receive the
Finished. In 1.1.1 we need to do it this way anyway because there is no
CCS (except in middlebox compat mode) in TLSv1.3.

Coincidentally, this commit also fixes the fact that no-nextprotoneg does
not currently work in master.

Reviewed-by: Andy Polyakov <appro at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/5285)

View the changeset: https://github.com/openssl/openssl/compare/368297d17352...5d671101739f

View the full build log and details: https://travis-ci.org/openssl/openssl/builds/339511350?utm_source=email&utm_medium=notification


You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mta.openssl.org/pipermail/openssl-commits/attachments/20180209/f6396d31/attachment.html>

More information about the openssl-commits mailing list