[openssl-commits] [openssl] master update

Rich Salz rsalz at openssl.org
Thu Feb 22 18:54:30 UTC 2018


The branch master has been updated
       via  d16a2c1931534cfc798a15c255e17180844d2ceb (commit)
      from  6f4b929af0b7dfb6a4d420fc9a8e25016f616c10 (commit)


- Log -----------------------------------------------------------------
commit d16a2c1931534cfc798a15c255e17180844d2ceb
Author: Steve Linsell <stevenx.linsell at intel.com>
Date:   Thu Feb 22 13:24:13 2018 -0500

    initialise dc variable to satisfy old compilers.
    
    When compiling with -Wall on a machine with an old compiler it gives a false
    positive that the dc variable which is a structure of type DISPLAY_COLUMNS
    could be used uninitialised. In fact the dc variable's members will always get
    set in the case it is used, otherwise it is left uninitialised.
    This fix just causes the dc variable's members to always get initialised to 0
    at declaration, so the false positive will not get flagged.
    
    Reviewed-by: Richard Levitte <levitte at openssl.org>
    Reviewed-by: Rich Salz <rsalz at openssl.org>
    (Merged from https://github.com/openssl/openssl/pull/5337)

-----------------------------------------------------------------------

Summary of changes:
 apps/openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/openssl.c b/apps/openssl.c
index fffa05e..39b4f2c 100644
--- a/apps/openssl.c
+++ b/apps/openssl.c
@@ -520,7 +520,7 @@ static void list_type(FUNC_TYPE ft, int one)
 {
     FUNCTION *fp;
     int i = 0;
-    DISPLAY_COLUMNS dc;
+    DISPLAY_COLUMNS dc = {0};
 
     if (!one)
         calculate_columns(&dc);


More information about the openssl-commits mailing list