[openssl-commits] Passed: openssl/openssl#16626 (OpenSSL_1_1_0-stable - 5eb9a42)

Travis CI builds at travis-ci.org
Tue Feb 27 18:09:56 UTC 2018


Build Update for openssl/openssl
-------------------------------------

Build: #16626
Status: Passed

Duration: 15 minutes and 54 seconds
Commit: 5eb9a42 (OpenSSL_1_1_0-stable)
Author: Dr. Matthias St. Pierre
Message: bio_b64.c: prevent base64 filter BIO from decoding out-of-bound data

Fixes #5405, #1381

The base64 filter BIO reads its input in chunks of B64_BLOCK_SIZE bytes.
When processing input in PEM format it can happen in rare cases that

- the trailing PEM marker crosses the boundary of a chunk, and
- the beginning of the following chunk contains valid base64 encoded data.

This happened in issue #5405, where the PEM marker was split into
"-----END CER" and "TIFICATE-----" at the end of the first chunk.

The decoding of the first chunk terminated correctly at the '-' character,
which is treated as an EOF marker, and b64_read() returned. However,
when called the second time, b64_read() read the next chunk and interpreted
the string "TIFICATE" as valid base64 encoded data, adding 6 extra bytes
'4c 81 48 08 04 c4'.

This patch restores the assignment of the error code to 'ctx->cont', which
was deleted accidentally in commit 5562cfaca4f3 and which prevents b64_read()
from reading additional data on subsequent calls.

This issue was observed and reported by Annie Yousar.

Reviewed-by: Richard Levitte <levitte at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/5422)

View the changeset: https://github.com/openssl/openssl/compare/4974a6f21b3e...5eb9a426d953

View the full build log and details: https://travis-ci.org/openssl/openssl/builds/346893637?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mta.openssl.org/pipermail/openssl-commits/attachments/20180227/ed2bbcd7/attachment.html>


More information about the openssl-commits mailing list