[openssl-commits] Passed: openssl/openssl#16639 (master - 8a5d8bc)

Travis CI builds at travis-ci.org
Wed Feb 28 00:24:32 UTC 2018

Build Update for openssl/openssl

Build: #16639
Status: Passed

Duration: 32 minutes and 45 seconds
Commit: 8a5d8bc (master)
Author: David Benjamin
Message: Always use adr with __thumb2__.

Thumb2 addresses are a bit a mess, depending on whether a label is
interpreted as a function pointer value (for use with BX and BLX) or as
a program counter value (for use with PC-relative addressing). Clang's
integrated assembler mis-assembles this code. See
https://crbug.com/124610#c54 for details.

Instead, use the ADR pseudo-instruction which has clear semantics and
should be supported by every assembler that handles the OpenSSL Thumb2
code. (In other files, the ADR vs SUB conditionals are based on
__thumb2__ already. For some reason, this one is based on __APPLE__, I'm
guessing to deal with an older version of clang assembler.)

It's unclear to me which of clang or binutils is "correct" or if this is
even a well-defined notion beyond "whatever binutils does". But I will
note that https://github.com/openssl/openssl/pull/4669 suggests binutils
has also changed behavior around this before.

Reviewed-by: Andy Polyakov <appro at openssl.org>
Reviewed-by: Rich Salz <rsalz at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/5431)

View the changeset: https://github.com/openssl/openssl/compare/89f66fe2bc4f...8a5d8bc4bc1e

View the full build log and details: https://travis-ci.org/openssl/openssl/builds/347051163?utm_source=email&utm_medium=notification


You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mta.openssl.org/pipermail/openssl-commits/attachments/20180228/58a2f6c5/attachment.html>

More information about the openssl-commits mailing list