[openssl-commits] [openssl] OpenSSL_1_1_0-stable update

Richard Levitte levitte at openssl.org
Thu Jan 18 10:30:23 UTC 2018


The branch OpenSSL_1_1_0-stable has been updated
       via  3469f386316cb0e520fa513d45e2b1f73a692449 (commit)
      from  634c1a6b752830d6631a9a8e7884b2f600aca696 (commit)


- Log -----------------------------------------------------------------
commit 3469f386316cb0e520fa513d45e2b1f73a692449
Author: Richard Levitte <levitte at openssl.org>
Date:   Thu Jan 18 10:54:48 2018 +0100

    TLSProxy::Proxy: Don't use ReuseAddr on Windows
    
    On Windows, we sometimes see a behavior with SO_REUSEADDR where there
    remains lingering listening sockets on the same address and port as a
    newly created one.
    
    An easy solution is not to use ReuseAddr on Windows.
    
    Thanks Bernd Edlinger for the suggestion.
    
    Reviewed-by: Bernd Edlinger <bernd.edlinger at hotmail.de>
    (Merged from https://github.com/openssl/openssl/pull/5103)
    
    (cherry picked from commit e02d5886636095c26a8bff1bf8344bd0bba7ccff)

-----------------------------------------------------------------------

Summary of changes:
 util/perl/TLSProxy/Proxy.pm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/util/perl/TLSProxy/Proxy.pm b/util/perl/TLSProxy/Proxy.pm
index e30b0aa..6ed13e3 100644
--- a/util/perl/TLSProxy/Proxy.pm
+++ b/util/perl/TLSProxy/Proxy.pm
@@ -178,13 +178,15 @@ sub clientstart
     # Create the Proxy socket
     my $proxaddr = $self->proxy_addr;
     $proxaddr =~ s/[\[\]]//g; # Remove [ and ]
-    my $proxy_sock = $IP_factory->(
+    my @proxyargs = (
         LocalHost   => $proxaddr,
         LocalPort   => $self->proxy_port,
         Proto       => "tcp",
         Listen      => SOMAXCONN,
-        ReuseAddr   => 1
-    );
+       );
+    push @proxyargs, ReuseAddr => 1
+        unless $^O eq "MSWin32";
+    my $proxy_sock = $IP_factory->(@proxyargs);
 
     if ($proxy_sock) {
         print "Proxy started on port ".$self->proxy_port."\n";


More information about the openssl-commits mailing list