[openssl-commits] [openssl] OpenSSL_1_0_2-stable update

[bernd.edlinger at hotmail.de]

The branch OpenSSL_1_0_2-stable has been updated
       via  da25dc2985a93ffade1f3467b496eb53577a1f8c (commit)
      from  00cd974f46f8d61896fdf3ca2b238f88e5b9216f (commit)


- Log -----------------------------------------------------------------
commit da25dc2985a93ffade1f3467b496eb53577a1f8c
Author: Bernd Edlinger <bernd.edlinger at hotmail.de>
Date:   Fri Mar 2 09:27:39 2018 +0100

    Fix a possible memory leak in engine_table_register
    
    Reviewed-by: Rich Salz <rsalz at openssl.org>
    (Merged from https://github.com/openssl/openssl/pull/5489)
    
    (cherry picked from commit 55a7f77d72930f9aee1a51e0af9658b2728be127)

-----------------------------------------------------------------------

Summary of changes:
 crypto/engine/eng_table.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/crypto/engine/eng_table.c b/crypto/engine/eng_table.c
index 27d31f7..5049fd6 100644
--- a/crypto/engine/eng_table.c
+++ b/crypto/engine/eng_table.c
@@ -159,6 +159,11 @@ int engine_table_register(ENGINE_TABLE **table, ENGINE_CLEANUP_CB *cleanup,
             }
             fnd->funct = NULL;
             (void)lh_ENGINE_PILE_insert(&(*table)->piles, fnd);
+            if (lh_ENGINE_PILE_retrieve(&(*table)->piles, &tmplate) != fnd) {
+                sk_ENGINE_free(fnd->sk);
+                OPENSSL_free(fnd);
+                goto end;
+            }
         }
         /* A registration shouldn't add duplciate entries */
         (void)sk_ENGINE_delete_ptr(fnd->sk, e);