[openssl-commits] Passed: openssl/openssl#16848 (master - d8b67b9)

Travis CI builds at travis-ci.org
Wed Mar 7 17:43:27 UTC 2018

Build Update for openssl/openssl

Build: #16848
Status: Passed

Duration: 35 minutes and 18 seconds
Commit: d8b67b9 (master)
Author: Matt Caswell
Message: Remove OPENSSL_USE_NODELETE guards in shlibloadtest

PR #3399 converted shlibloadtest to the new test framework. It also
seemed to add some `OPENSSL_USE_NODELETE` guards to the library
unloading part of the test. This part was added in a commit with this

    Review feedback; use single main, #ifdef ADD_TEST

    Suppose OPENSSL_USE_NODELETE (via Nick Reilly)

Strangely though there doesn't seem to be any relevant review feedback
in that PR that could justify the addition of those guards. The guards
do not appear in 1.1.0.

Having the guards changes the nature of the test, so that we only test
library unloading on platforms where OPENSSL_USE_NODELETE is set (Linux
and Windows). I can't think of any good reason for this and as it doesn't
seem to be necessary in 1.1.0 so I think we should remove them.

Reviewed-by: Richard Levitte <levitte at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/5530)

View the changeset: https://github.com/openssl/openssl/compare/3e3c7c364687...d8b67b9d0f71

View the full build log and details: https://travis-ci.org/openssl/openssl/builds/350398316?utm_source=email&utm_medium=notification


You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mta.openssl.org/pipermail/openssl-commits/attachments/20180307/361e1793/attachment.html>

More information about the openssl-commits mailing list