[openssl-commits] Still Failing: openssl/openssl#16954 (master - ee36b96)

Travis CI builds at travis-ci.org
Fri Mar 9 18:04:09 UTC 2018

Build Update for openssl/openssl

Build: #16954
Status: Still Failing

Duration: 37 minutes and 10 seconds
Commit: ee36b96 (master)
Author: Benjamin Kaduk
Message: Reuse extension_is_relevant() in should_add_extension()

At the core of things is the concept that each extension is only
defined in certain context(s) -- the ClientHello, EncryptedExtensions,
etc., and sometimes only for a specific protocol or protocol range;
we want to enforce that we only parse or generate extensions in the
context(s) for which they are defined.  There is some subtlety here,
in that the protocol version in use is not known when generating the
ClientHello (but it is known when the ClientHello extensions are
being parsed!), so the SSL_IS_TLS13() macro must be used with caution.
Nonetheless, by making assertions about whether we are acting in a
server role and whether the current context is (not) a ClientHello,
we can consolidate almost all of the logic for determining whether
an extension is permitted in a given protocol message, whether we
are generating or parsing that message.

The only logic that remains separate relates to generating the ClientHello,
as it depends on an external factor (the maximum permitted TLS version) that
is not defined in the parsing context.

Reviewed-by: Matt Caswell <matt at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/2945)

View the changeset: https://github.com/openssl/openssl/compare/b0143b975299...ee36b963aef8

View the full build log and details: https://travis-ci.org/openssl/openssl/builds/351408844?utm_source=email&utm_medium=notification


You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

This email was sent to openssl-commits at openssl.org (mailto:openssl-commits at openssl.org)
unsubscribe from this list (http://clicks.travis-ci.com/track/unsub.php?u=14313403&id=68c240255ad84b86b24517710b355f39.S4RW6Clmvqc3YBhWrklxhpwfgC8%3D&r=https%3A%2F%2Fmandrillapp.com%2Funsub%3Fmd_email%3Dopenssl-commits%2540openssl.org)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mta.openssl.org/pipermail/openssl-commits/attachments/20180309/1dec5ef4/attachment.html>

More information about the openssl-commits mailing list