[openssl-commits] [openssl] master update

[Paul I. Dale]

The branch master has been updated
       via  2167640b0bf76ec50a397dd90444b97c242e3f04 (commit)
      from  64ed55ab033f1bfa795d46f0ecc61c313204b418 (commit)


- Log -----------------------------------------------------------------
commit 2167640b0bf76ec50a397dd90444b97c242e3f04
Author: Eric Curtin <ericcurtin17 at gmail.com>
Date:   Mon Sep 3 15:23:37 2018 +0100

    New openssl subject parser hard to debug
    
    -subj 'subject=C = US, ST = A, L = root, O = Hewlett Packard Enterprise Company, OU = Remote Device Access, CN = Hewlett Packard Enterprise Remote Device Access Test Local CA, emailAddress = rda at hpe.com'
    was a valid subject in openssl 1.0. Error received in 1.1 is:
    
    problems making Certificate Request
    
    Not very informative, I only figured this out because I compiled the
    code and added logging.
    
    Reviewed-by: Tim Hudson <tjh at openssl.org>
    Reviewed-by: Paul Dale <paul.dale at oracle.com>
    (Merged from https://github.com/openssl/openssl/pull/7098)

-----------------------------------------------------------------------

Summary of changes:
 apps/apps.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/apps/apps.c b/apps/apps.c
index 4090e60..9be6560 100644
--- a/apps/apps.c
+++ b/apps/apps.c
@@ -1768,8 +1768,14 @@ X509_NAME *parse_name(const char *cp, long chtype, int canmulti)
     char *work;
     X509_NAME *n;
 
-    if (*cp++ != '/')
+    if (*cp++ != '/') {
+        BIO_printf(bio_err,
+                   "name is expected to be in the format "
+                   "/type0=value0/type1=value1/type2=... where characters may "
+                   "be escaped by \\. This name is not in that format: '%s'\n",
+                   --cp);
         return NULL;
+    }
 
     n = X509_NAME_new();
     if (n == NULL)