[openssl-commits] [openssl] master update

[Richard Levitte]

The branch master has been updated
       via  f11ffa505f8a9345145a26a05bf77b012b6941bd (commit)
      from  008b4ff92f785cf3808df26ac5b23f25a691b23c (commit)


- Log -----------------------------------------------------------------
commit f11ffa505f8a9345145a26a05bf77b012b6941bd
Author: Richard Levitte <levitte at openssl.org>
Date:   Thu Feb 14 09:25:40 2019 +0100

    Configure: stop forcing use of DEFINE macros in headers
    
    There are times when one might want to use something like
    DEFINE_STACK_OF in a .c file, because it defines a stack for a type
    defined in that .c file.  Unfortunately, when configuring with
    `--strict-warnings`, clang aggressively warn about unused functions in
    such cases, which forces the use of such DEFINE macros to header
    files.
    
    We therefore disable this warning from the `--strict-warnings`
    definition for clang.
    
    (note for the curious: `-Wunused-function` is enabled via `-Wall`)
    
    Reviewed-by: Paul Dale <paul.dale at oracle.com>
    (Merged from https://github.com/openssl/openssl/pull/8234)

-----------------------------------------------------------------------

Summary of changes:
 Configure | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Configure b/Configure
index d6ae2be..0f5807c 100755
--- a/Configure
+++ b/Configure
@@ -145,6 +145,8 @@ my $gcc_devteam_warn = "-DDEBUG_UNUSED"
 #       -Wlanguage-extension-token -- no, we use asm()
 #       -Wunused-macros -- no, too tricky for BN and _XOPEN_SOURCE etc
 #       -Wextended-offsetof -- no, needed in CMS ASN1 code
+#       -Wunused-function -- no, it forces header use of safestack et al
+#                            DEFINE macros
 my $clang_devteam_warn = ""
         . " -Wswitch-default"
         . " -Wno-parentheses-equality"
@@ -154,6 +156,7 @@ my $clang_devteam_warn = ""
         . " -Wincompatible-pointer-types-discards-qualifiers"
         . " -Wmissing-variable-declarations"
         . " -Wno-unknown-warning-option"
+        . " -Wno-unused-function"
         ;
 
 # This adds backtrace information to the memory leak info.  Is only used