[openssl-commits] [openssl] OpenSSL_1_1_1-stable update
Richard Levitte
levitte at openssl.org
Thu Feb 14 08:47:22 UTC 2019
The branch OpenSSL_1_1_1-stable has been updated
via cd272eeee23b5866b281303550917287e78375c1 (commit)
from 7ee28a61cd6d9f704fc672904a14a764f618aa7c (commit)
- Log -----------------------------------------------------------------
commit cd272eeee23b5866b281303550917287e78375c1
Author: Richard Levitte <levitte at openssl.org>
Date: Thu Feb 14 09:25:40 2019 +0100
Configure: stop forcing use of DEFINE macros in headers
There are times when one might want to use something like
DEFINE_STACK_OF in a .c file, because it defines a stack for a type
defined in that .c file. Unfortunately, when configuring with
`--strict-warnings`, clang aggressively warn about unused functions in
such cases, which forces the use of such DEFINE macros to header
files.
We therefore disable this warning from the `--strict-warnings`
definition for clang.
(note for the curious: `-Wunused-function` is enabled via `-Wall`)
Reviewed-by: Paul Dale <paul.dale at oracle.com>
(Merged from https://github.com/openssl/openssl/pull/8234)
(cherry picked from commit f11ffa505f8a9345145a26a05bf77b012b6941bd)
-----------------------------------------------------------------------
Summary of changes:
Configure | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Configure b/Configure
index 7b9501a..d300a76 100755
--- a/Configure
+++ b/Configure
@@ -144,6 +144,8 @@ my $gcc_devteam_warn = "-DDEBUG_UNUSED"
# -Wlanguage-extension-token -- no, we use asm()
# -Wunused-macros -- no, too tricky for BN and _XOPEN_SOURCE etc
# -Wextended-offsetof -- no, needed in CMS ASN1 code
+# -Wunused-function -- no, it forces header use of safestack et al
+# DEFINE macros
my $clang_devteam_warn = ""
. " -Wswitch-default"
. " -Wno-parentheses-equality"
@@ -153,6 +155,7 @@ my $clang_devteam_warn = ""
. " -Wincompatible-pointer-types-discards-qualifiers"
. " -Wmissing-variable-declarations"
. " -Wno-unknown-warning-option"
+ . " -Wno-unused-function"
;
# This adds backtrace information to the memory leak info. Is only used
More information about the openssl-commits
mailing list