[openssl-commits] Errored: openssl/openssl#22529 (OpenSSL_1_1_1-stable - bbcfd60)

Travis CI builds at travis-ci.org
Tue Jan 8 17:26:41 UTC 2019


Build Update for openssl/openssl
-------------------------------------

Build: #22529
Status: Errored

Duration: 8 mins and 53 secs
Commit: bbcfd60 (OpenSSL_1_1_1-stable)
Author: Matt Caswell
Message: Don't artificially limit the size of the ClientHello

We were setting a limit of SSL3_RT_MAX_PLAIN_LENGTH on the size of the
ClientHello. AFAIK there is nothing in the standards that requires this
limit.

The limit goes all the way back to when support for extensions was first
added for TLSv1.0. It got converted into a WPACKET max size in 1.1.1. Most
likely it was originally added to avoid the complexity of having to grow
the init_buf in the middle of adding extensions. With WPACKET this is
irrelevant since it will grow automatically.

This issue came up when an attempt was made to send a very large
certificate_authorities extension in the ClientHello.

We should just remove the limit.

Reviewed-by: Paul Dale <paul.dale at oracle.com>
Reviewed-by: Viktor Dukhovni <viktor at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/7424)

(cherry picked from commit 7835e97b6ff5cd94a10c5aeac439f4aa145a77b2)

View the changeset: https://github.com/openssl/openssl/compare/37cad7e65641...bbcfd60e388a

View the full build log and details: https://travis-ci.org/openssl/openssl/builds/476936224?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the openssl/openssl repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=5849220&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mta.openssl.org/pipermail/openssl-commits/attachments/20190108/7d1d6885/attachment-0001.html>


More information about the openssl-commits mailing list