Still Failing: openssl/openssl#26631 (master - 3b438ef)

Travis CI builds at travis-ci.org
Thu Jul 18 04:43:15 UTC 2019


Build Update for openssl/openssl
-------------------------------------

Build: #26631
Status: Still Failing

Duration: 20 mins and 11 secs
Commit: 3b438ef (master)
Author: Dr. Matthias St. Pierre
Message: Fix init_get_thread_local()

Previously, init_get_thread_local() pushed the thread event handler
list onto the global register before calling CRYPTO_THREAD_set_local(),
and when the latter failed, forgot to pop the list from the stack again.

Instead of cleaning the stack on error, this commit avoids the situation
entirely by postponing the push operation until all other operations
succeeded. This reordering also significantly reduces the scope of the
critical section.

Another simplification of the code is achieved by moving the push operation
onto the register (which is disabled in FIPS mode) into a separate function.

Reviewed-by: Richard Levitte <levitte at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/9401)

View the changeset: https://github.com/openssl/openssl/compare/e7aa7c11c71e...3b438ef95b5b

View the full build log and details: https://travis-ci.org/openssl/openssl/builds/560306334?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the openssl/openssl repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=5849220&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mta.openssl.org/pipermail/openssl-commits/attachments/20190718/32056b88/attachment-0001.html>


More information about the openssl-commits mailing list