[openssl] master update

[bernd.edlinger at hotmail.de]

The branch master has been updated
       via  e7a4682d0b347f0dfba629f4601a28801e54ad67 (commit)
      from  e24bdcde5a80a7edeb1e0dbbcf45c3353a974974 (commit)


- Log -----------------------------------------------------------------
commit e7a4682d0b347f0dfba629f4601a28801e54ad67
Author: Bernd Edlinger <bernd.edlinger at hotmail.de>
Date:   Fri Jun 14 14:48:37 2019 +0200

    Fix error handling at openssl_strerror_r
    
    When bufsize == 0, openssl_strerror_r should return 0 (if _GNU_SOURCE is defined),
    to be consistent with non-_GNU_SOURCE variants, which exhibit the same behavior.
    Fix a few cases, where the return value of openssl_strerror_r was ignored.
    
    Reviewed-by: Paul Dale <paul.dale at oracle.com>
    (Merged from https://github.com/openssl/openssl/pull/9163)

-----------------------------------------------------------------------

Summary of changes:
 crypto/o_str.c             |  2 +-
 crypto/store/loader_file.c | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/crypto/o_str.c b/crypto/o_str.c
index 3b271e7..0403982 100644
--- a/crypto/o_str.c
+++ b/crypto/o_str.c
@@ -231,7 +231,7 @@ int openssl_strerror_r(int errnum, char *buf, size_t buflen)
      * buf is left unused.
      */
     err = strerror_r(errnum, buf, buflen);
-    if (err == NULL)
+    if (err == NULL || buflen == 0)
         return 0;
     /*
      * If err is statically allocated, err != buf and we need to copy the data.
diff --git a/crypto/store/loader_file.c b/crypto/store/loader_file.c
index cac8698..9011653 100644
--- a/crypto/store/loader_file.c
+++ b/crypto/store/loader_file.c
@@ -860,10 +860,10 @@ static OSSL_STORE_LOADER_CTX *file_open(const OSSL_STORE_LOADER *loader,
         if (ctx->_.dir.last_entry == NULL) {
             if (ctx->_.dir.last_errno != 0) {
                 char errbuf[256];
-                errno = ctx->_.dir.last_errno;
-                openssl_strerror_r(errno, errbuf, sizeof(errbuf));
                 OSSL_STOREerr(OSSL_STORE_F_FILE_OPEN, ERR_R_SYS_LIB);
-                ERR_add_error_data(1, errbuf);
+                errno = ctx->_.dir.last_errno;
+                if (openssl_strerror_r(errno, errbuf, sizeof(errbuf)))
+                    ERR_add_error_data(1, errbuf);
                 goto err;
             }
             ctx->_.dir.end_reached = 1;
@@ -1260,11 +1260,11 @@ static OSSL_STORE_INFO *file_load(OSSL_STORE_LOADER_CTX *ctx,
                 if (!ctx->_.dir.end_reached) {
                     char errbuf[256];
                     assert(ctx->_.dir.last_errno != 0);
+                    OSSL_STOREerr(OSSL_STORE_F_FILE_LOAD, ERR_R_SYS_LIB);
                     errno = ctx->_.dir.last_errno;
                     ctx->errcnt++;
-                    openssl_strerror_r(errno, errbuf, sizeof(errbuf));
-                    OSSL_STOREerr(OSSL_STORE_F_FILE_LOAD, ERR_R_SYS_LIB);
-                    ERR_add_error_data(1, errbuf);
+                    if (openssl_strerror_r(errno, errbuf, sizeof(errbuf)))
+                        ERR_add_error_data(1, errbuf);
                 }
                 return NULL;
             }