Still Failing: openssl/openssl#30281 (master - 2a53855)

Travis CI builds at
Fri Nov 22 03:08:16 UTC 2019

Build Update for openssl/openssl

Build: #30281
Status: Still Failing

Duration: 37 mins and 38 secs
Commit: 2a53855 (master)
Author: Benjamin Kaduk
Message: Fix a race condition in SNI handling

As was done for ciphers, supported groups, and EC point formats in, only write the negotiated
SNI hostname value to the session object when not resuming, even for
TLS 1.3 resumptions.  Otherwise, when using a stateful session cache
(as is done by default when 0-RTT data is enabled), we can have multiple
SSLs active using the same in-memory session object, which leads to
double-frees and similar race conditions in the SNI handler prior
to this commit.

Fortunately, since draft-ietf-tls-tls13-22, there is no requirement
that the SNI hostname be preserved across TLS 1.3 resumption, and thus
not a need to continually update the session object with the "current"
value (to be used when producing session tickets, so that the subsequent
resumption can be checked against the current value).  So we can just
relax the logic and only write to the session object for initial handshakes.
This still leaves us in a somewhat inconsistent state, since if the SNI value
does change across handshakes, the session object will continue to record
the initial handshake's value, even if that bears no relation to the
current handshake.  The current SSL_get_servername() implementation
prefers the value from the session if s->hit, but a more complete fix
for that and related issues is underway in; there is no need to wait
for the complete fix for SNI name handling in order to close the
race condition and avoid runtime crashes.

Reviewed-by: Matt Caswell <matt at>
(Merged from

View the changeset:

View the full build log and details:


You can unsubscribe from build emails from the openssl/openssl repository going to
Or unsubscribe from *all* email updating your settings at
Or configure specific recipients for build notifications in your .travis.yml file. See

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the openssl-commits mailing list