[openssl] OpenSSL_1_0_2-stable update
nic.tuv at gmail.com
nic.tuv at gmail.com
Wed Oct 16 13:07:15 UTC 2019
The branch OpenSSL_1_0_2-stable has been updated
via 0159a1bb41b385a00836e9e7baeadad2f014b788 (commit)
from 4e545c6a256fb1ab08cc5a3aabb00963dac3191b (commit)
- Log -----------------------------------------------------------------
commit 0159a1bb41b385a00836e9e7baeadad2f014b788
Author: Cesar Pereida Garcia <cesar.pereidagarcia at tut.fi>
Date: Thu Sep 12 17:09:51 2019 +0300
[crypto/asn1/x_bignum.c] Explicit test against NULL
As a fixup to https://github.com/openssl/openssl/pull/9779 to better
conform to the project code style guidelines, this commit amends the
original changeset to explicitly test against NULL, i.e. writing
```
if (p != NULL)
```
rather than
```
if (!p)
```
(This is a backport of https://github.com/openssl/openssl/pull/9881)
Reviewed-by: Nicola Tuveri <nic.tuv at gmail.com>
Reviewed-by: Matt Caswell <matt at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/9882)
-----------------------------------------------------------------------
Summary of changes:
crypto/asn1/x_bignum.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/crypto/asn1/x_bignum.c b/crypto/asn1/x_bignum.c
index c644199c9f..f2de3de4de 100644
--- a/crypto/asn1/x_bignum.c
+++ b/crypto/asn1/x_bignum.c
@@ -102,7 +102,7 @@ ASN1_ITEM_end(CBIGNUM)
static int bn_new(ASN1_VALUE **pval, const ASN1_ITEM *it)
{
*pval = (ASN1_VALUE *)BN_new();
- if (*pval)
+ if (*pval != NULL)
return 1;
else
return 0;
@@ -110,7 +110,7 @@ static int bn_new(ASN1_VALUE **pval, const ASN1_ITEM *it)
static void bn_free(ASN1_VALUE **pval, const ASN1_ITEM *it)
{
- if (!*pval)
+ if (*pval == NULL)
return;
if (it->size & BN_SENSITIVE)
BN_clear_free((BIGNUM *)*pval);
@@ -124,7 +124,7 @@ static int bn_i2c(ASN1_VALUE **pval, unsigned char *cont, int *putype,
{
BIGNUM *bn;
int pad;
- if (!*pval)
+ if (*pval == NULL)
return -1;
bn = (BIGNUM *)*pval;
/* If MSB set in an octet we need a padding byte */
More information about the openssl-commits
mailing list