[openssl] master update

tomas at openssl.org tomas at openssl.org
Thu Apr 1 13:21:56 UTC 2021


The branch master has been updated
       via  975e37cd016f86985d16f1ee646e88213494854a (commit)
      from  78043fe898f4dac862a515f9a1b1bbe6dda22951 (commit)


- Log -----------------------------------------------------------------
commit 975e37cd016f86985d16f1ee646e88213494854a
Author: Nan Xiao <nan at chinadtrace.org>
Date:   Mon Mar 29 17:24:01 2021 +0800

    Remove unnecessary BIO_do_handshake()s
    
    Since BIO_do_connect() and BIO_do_handshake() are same, no
    need to invoke BIO_do_handshake() once more after BIO_do_connect().
    
    Reviewed-by: Paul Dale <pauli at openssl.org>
    Reviewed-by: Tomas Mraz <tomas at openssl.org>
    (Merged from https://github.com/openssl/openssl/pull/14725)

-----------------------------------------------------------------------

Summary of changes:
 demos/bio/client-arg.c  | 6 ------
 demos/bio/client-conf.c | 6 ------
 doc/man3/BIO_f_ssl.pod  | 5 -----
 3 files changed, 17 deletions(-)

diff --git a/demos/bio/client-arg.c b/demos/bio/client-arg.c
index 976fefff5d..27c4c98f96 100644
--- a/demos/bio/client-arg.c
+++ b/demos/bio/client-arg.c
@@ -94,12 +94,6 @@ int main(int argc, char **argv)
         goto end;
     }
 
-    if (BIO_do_handshake(sbio) <= 0) {
-        fprintf(stderr, "Error establishing SSL connection\n");
-        ERR_print_errors_fp(stderr);
-        goto end;
-    }
-
     /* Could examine ssl here to get connection info */
 
     BIO_puts(sbio, "GET / HTTP/1.0\n\n");
diff --git a/demos/bio/client-conf.c b/demos/bio/client-conf.c
index 84edc796dc..270df377e7 100644
--- a/demos/bio/client-conf.c
+++ b/demos/bio/client-conf.c
@@ -102,12 +102,6 @@ int main(int argc, char **argv)
         goto end;
     }
 
-    if (BIO_do_handshake(sbio) <= 0) {
-        fprintf(stderr, "Error establishing SSL connection\n");
-        ERR_print_errors_fp(stderr);
-        goto end;
-    }
-
     /* Could examine ssl here to get connection info */
 
     BIO_puts(sbio, "GET / HTTP/1.0\n\n");
diff --git a/doc/man3/BIO_f_ssl.pod b/doc/man3/BIO_f_ssl.pod
index 6a21e0c41c..8eee317c7a 100644
--- a/doc/man3/BIO_f_ssl.pod
+++ b/doc/man3/BIO_f_ssl.pod
@@ -188,11 +188,6 @@ unencrypted example in L<BIO_s_connect(3)>.
      ERR_print_errors_fp(stderr);
      exit(1);
  }
- if (BIO_do_handshake(sbio) <= 0) {
-     fprintf(stderr, "Error establishing SSL connection\n");
-     ERR_print_errors_fp(stderr);
-     exit(1);
- }
 
  /* XXX Could examine ssl here to get connection info */
 


More information about the openssl-commits mailing list