[openssl] master update

beldmit at gmail.com beldmit at gmail.com
Thu Apr 29 11:54:26 UTC 2021


The branch master has been updated
       via  0f077b5fd86e2df0b41608fbd5684fa1a2b58f59 (commit)
      from  c404e4fab3b4497a2d04bc9c171c5460b940bf91 (commit)


- Log -----------------------------------------------------------------
commit 0f077b5fd86e2df0b41608fbd5684fa1a2b58f59
Author: Scott McPeak <scott.g.mcpeak at gmail.com>
Date:   Thu Apr 22 19:13:09 2021 -0700

    asn1_lib.c: ASN1_put_object: Remove comment about "class 0".
    
    ASN1_put_object() was preceded by the nonsensical comment:
    
      /*
       * class 0 is constructed constructed == 2 for indefinite length constructed
       */
    
    This is the result of concatenating two sentences in 0f113f3ee4d by
    automated reformatting.  The first sentence, "class 0 is constructed",
    goes back to d02b48c63a, the import of SSLeay 0.8.1b.  Even in that
    context, it made little sense; class 0 means "universal", not
    constructed, and there is no special significance to class 0 in this
    function in any case.
    
    Therefore I have simply removed that first sentence.
    
    CLA: trivial
    
    Reviewed-by: Tomas Mraz <tomas at openssl.org>
    Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
    (Merged from https://github.com/openssl/openssl/pull/14998)

-----------------------------------------------------------------------

Summary of changes:
 crypto/asn1/asn1_lib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/asn1/asn1_lib.c b/crypto/asn1/asn1_lib.c
index 72d15acc7e..b1fa6b55a0 100644
--- a/crypto/asn1/asn1_lib.c
+++ b/crypto/asn1/asn1_lib.c
@@ -155,7 +155,7 @@ static int asn1_get_length(const unsigned char **pp, int *inf, long *rl,
 }
 
 /*
- * class 0 is constructed constructed == 2 for indefinite length constructed
+ * constructed == 2 for indefinite length constructed
  */
 void ASN1_put_object(unsigned char **pp, int constructed, int length, int tag,
                      int xclass)


More information about the openssl-commits mailing list