[openssl] openssl-3.0 update
Dr. Paul Dale
pauli at openssl.org
Thu Dec 23 01:32:28 UTC 2021
The branch openssl-3.0 has been updated
via 317bedd656e76b1162a6b29ed19a78303f362a78 (commit)
from ceeb92f7b52fbbb349cca8d9560a0708d948936a (commit)
- Log -----------------------------------------------------------------
commit 317bedd656e76b1162a6b29ed19a78303f362a78
Author: Alexandros Roussos <thealexroussos at gmail.com>
Date: Mon Dec 20 19:14:57 2021 +0100
Fix Configure variable spill
* Evaluating code-refs in Configure can sometimes set the default
variable `$_`
* Prevent spillage influencing the target property by using named
variable in loop
CLA: trivial
Fixes gh-17321
Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/17322)
(cherry picked from commit a595e3286ae9f033c56452967b3add2145f9085f)
-----------------------------------------------------------------------
Summary of changes:
Configure | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/Configure b/Configure
index b00b91ac63..df7232d551 100755
--- a/Configure
+++ b/Configure
@@ -3169,25 +3169,25 @@ sub resolve_config {
}
}
- foreach (sort keys %all_keys) {
- my $previous = $combined_inheritance{$_};
+ foreach my $key (sort keys %all_keys) {
+ my $previous = $combined_inheritance{$key};
# Current target doesn't have a value for the current key?
# Assign it the default combiner, the rest of this loop body
# will handle it just like any other coderef.
- if (!exists $table{$target}->{$_}) {
- $table{$target}->{$_} = $default_combiner;
+ if (!exists $table{$target}->{$key}) {
+ $table{$target}->{$key} = $default_combiner;
}
- $table{$target}->{$_} = process_values($table{$target}->{$_},
- $combined_inheritance{$_},
- $target, $_);
- unless(defined($table{$target}->{$_})) {
- delete $table{$target}->{$_};
+ $table{$target}->{$key} = process_values($table{$target}->{$key},
+ $combined_inheritance{$key},
+ $target, $key);
+ unless(defined($table{$target}->{$key})) {
+ delete $table{$target}->{$key};
}
# if ($extra_checks &&
-# $previous && !($add_called || $previous ~~ $table{$target}->{$_})) {
-# warn "$_ got replaced in $target\n";
+# $previous && !($add_called || $previous ~~ $table{$target}->{$key})) {
+# warn "$key got replaced in $target\n";
# }
}
More information about the openssl-commits
mailing list