[openssl] master update
Dr. Paul Dale
pauli at openssl.org
Sun Mar 14 05:36:09 UTC 2021
The branch master has been updated
via 8bfb8f34580cac3a53b0ac88dec566c19d6c8c53 (commit)
from cd3f8c1b11b0b9f4163bc8c62cbae38aec1b4030 (commit)
- Log -----------------------------------------------------------------
commit 8bfb8f34580cac3a53b0ac88dec566c19d6c8c53
Author: Shane Lontis <shane.lontis at oracle.com>
Date: Fri Mar 12 12:53:14 2021 +1000
Remove TODO in test/acvp_test.c related to setting AES-GCM iv.
Fixes #14330
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14525)
-----------------------------------------------------------------------
Summary of changes:
test/acvp_test.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/test/acvp_test.c b/test/acvp_test.c
index 0be26f699b..cfed50b08d 100644
--- a/test/acvp_test.c
+++ b/test/acvp_test.c
@@ -837,8 +837,9 @@ static int aes_gcm_enc_dec(const char *alg,
goto err;
}
/*
- * TODO(3.0): The IV should not be set outside the boundary as it is now.
- * It needs to be fed in via a dummy entropy source for this test.
+ * For testing purposes the IV it being set here. In a compliant application
+ * the IV would be generated internally. A fake entropy source could also
+ * be used to feed in the random IV bytes (see fake_random.c)
*/
if (!TEST_true(EVP_CipherInit_ex(ctx, NULL, NULL, key, iv, enc))
|| !TEST_true(EVP_CIPHER_CTX_set_padding(ctx, 0))
More information about the openssl-commits
mailing list