[openssl/openssl] b20158: siphash: Fail finalization on uninitialized siphas...

Tomas Mraz noreply at reply.github.openssl.org
Wed Apr 27 08:06:05 UTC 2022


  Branch: refs/heads/openssl-3.0
  Home:   https://github.openssl.org/openssl/openssl
  Commit: b2015891c4edd99284a4b9ec97ee4ac61e57c310
      https://github.openssl.org/openssl/openssl/commit/b2015891c4edd99284a4b9ec97ee4ac61e57c310
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2022-04-27 (Wed, 27 Apr 2022)

  Changed paths:
    M crypto/siphash/siphash.c

  Log Message:
  -----------
  siphash: Fail finalization on uninitialized siphash context

Fixes #18140

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Matt Caswell <matt at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18142)

(cherry picked from commit 650b142c2e4c1d57868bdbbe1f7f4549ee77f8eb)


  Commit: 6893e691d8dafe8fb74585f6c23f1ca8d70f97a9
      https://github.openssl.org/openssl/openssl/commit/6893e691d8dafe8fb74585f6c23f1ca8d70f97a9
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2022-04-27 (Wed, 27 Apr 2022)

  Changed paths:
    M providers/implementations/macs/siphash_prov.c

  Log Message:
  -----------
  siphash: Properly set mac size in sipcopy

Also fully duplicate the context on dup

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Matt Caswell <matt at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18142)

(cherry picked from commit 905fec4f4d6bb8a978476cbce0f293ffc683b5fd)


  Commit: c1a5e4c564742354148e3aab1f81a9b0177e832c
      https://github.openssl.org/openssl/openssl/commit/c1a5e4c564742354148e3aab1f81a9b0177e832c
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2022-04-27 (Wed, 27 Apr 2022)

  Changed paths:
    M test/siphash_internal_test.c

  Log Message:
  -----------
  Test that SipHash_Final() fails on uninited context

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Matt Caswell <matt at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18142)

(cherry picked from commit 4b694f29ea78ab8a94e67c89d4d81df18c5e3bf1)


Compare: https://github.openssl.org/openssl/openssl/compare/92bab433d77e...c1a5e4c56474


More information about the openssl-commits mailing list