[openssl/openssl] b304b3: Fix EC_KEY_set_private_key() priv_key regression

Roberto Hueso noreply at github.com
Thu Aug 4 09:57:04 UTC 2022


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: b304b3e8f7397c3e949e3664e6ceaee5dc811b32
      https://github.com/openssl/openssl/commit/b304b3e8f7397c3e949e3664e6ceaee5dc811b32
  Author: Roberto Hueso Gomez <roberto at robertohueso.org>
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
    M crypto/ec/ec_key.c

  Log Message:
  -----------
  Fix EC_KEY_set_private_key() priv_key regression

This allows to set EC_KEY's private key to NULL and fixes regression
issue following OTC guideline in
https://github.com/openssl/openssl/issues/18744#issuecomment-1195175696

Fixes #18744.

Reviewed-by: Nicola Tuveri <nic.tuv at gmail.com>
Reviewed-by: Todd Short <todd.short at me.com>
(Merged from https://github.com/openssl/openssl/pull/18942)


  Commit: d93f154d5a524e6ed71ff276447de7fe11d85949
      https://github.com/openssl/openssl/commit/d93f154d5a524e6ed71ff276447de7fe11d85949
  Author: Roberto Hueso Gomez <roberto at robertohueso.org>
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
    M test/ec_internal_test.c

  Log Message:
  -----------
  Add test for EC_KEY_set_private_key()

This tests the behavior and API of the EC_KEY_set_private_key function.
It tests compliance with legacy features related to NULL private keys
too.

Reviewed-by: Nicola Tuveri <nic.tuv at gmail.com>
Reviewed-by: Todd Short <todd.short at me.com>
(Merged from https://github.com/openssl/openssl/pull/18942)


  Commit: fae06b5779bd3e2e1af22b370f32e60efb59fcd6
      https://github.com/openssl/openssl/commit/fae06b5779bd3e2e1af22b370f32e60efb59fcd6
  Author: Roberto Hueso Gomez <roberto at robertohueso.org>
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
    M doc/man3/EC_KEY_new.pod

  Log Message:
  -----------
  Fix EC_KEY_set_private_key() NULL priv_key docs

Updates the docs to describe EC_KEY_set_private_key() function behavior
when a NULL priv_key argument is passed.

Reviewed-by: Nicola Tuveri <nic.tuv at gmail.com>
Reviewed-by: Todd Short <todd.short at me.com>
(Merged from https://github.com/openssl/openssl/pull/18942)


Compare: https://github.com/openssl/openssl/compare/0a90577e717f...fae06b5779bd


More information about the openssl-commits mailing list