[openssl/openssl] bbedc0: providers: Set the size of EC signature on s390.

openssl-machine noreply at github.com
Thu Aug 4 13:23:00 UTC 2022


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: bbedc052973b1c2fab7d7fb891d02aea393ff579
      https://github.com/openssl/openssl/commit/bbedc052973b1c2fab7d7fb891d02aea393ff579
  Author: Sebastian Andrzej Siewior <sebastian at breakpoint.cc>
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
    M providers/implementations/signature/eddsa_sig.c

  Log Message:
  -----------
  providers: Set the size of EC signature on s390.

The s390x provides its custom implementation for the creation of the
ed448 and ed25519 signatures. Unfortunately it does not set the size.
Users that rely of this return parameter end up with wrong values and
will compare wrong sizes of signature.

Set the proper size of the returned signature on success. Set an error
if the signing operation fails.

Fixes: #18912
Signed-off-by: Sebastian Andrzej Siewior <sebastian at breakpoint.cc>

Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Todd Short <todd.short at me.com>
(Merged from https://github.com/openssl/openssl/pull/18928)


  Commit: fc5888ccb60f33b366972299f30b976c4dc12162
      https://github.com/openssl/openssl/commit/fc5888ccb60f33b366972299f30b976c4dc12162
  Author: Sebastian Andrzej Siewior <sebastian at breakpoint.cc>
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
    M test/evp_test.c

  Log Message:
  -----------
  test/evp_test: Test if EVP_DigestSign() set signature's length.

Increase the signature's length, that is passed to EVP_DigestSign(). The
implementation should set this parameter back to the actual length, that
has been written.

This (oneshot_digestsign_test_run()) fails for the ed25519/ ed448
implementation of s390 prio the fix. The change in digestsign_test_run()
follows the same pattern and is for collecting bonus points.

Signed-off-by: Sebastian Andrzej Siewior <sebastian at breakpoint.cc>

Reviewed-by: Matt Caswell <matt at openssl.org>
Reviewed-by: Todd Short <todd.short at me.com>
(Merged from https://github.com/openssl/openssl/pull/18928)


Compare: https://github.com/openssl/openssl/compare/2bd8190aace8...fc5888ccb60f


More information about the openssl-commits mailing list