[openssl/openssl] 9e4b57: Don't incorrectly skip the multiblock test

Matt Caswell noreply at github.com
Wed Aug 17 15:51:03 UTC 2022


  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: 9e4b57fbe9544326e4c7119fe30e5319803f5e17
      https://github.com/openssl/openssl/commit/9e4b57fbe9544326e4c7119fe30e5319803f5e17
  Author: Matt Caswell <matt at openssl.org>
  Date:   2022-08-17 (Wed, 17 Aug 2022)

  Changed paths:
    M test/sslapitest.c

  Log Message:
  -----------
  Don't incorrectly skip the multiblock test

sslapitest has a test for multiblock writes. Since multiblock writing is
only available on some platforms the multiblock test checks whether we are
on such a platform first, and skips the test if we are not. Unfortunately
a bug in the check meant that we always skipped the test regardless of the
platform.

Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Hugo Landau <hlandau at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18983)

(cherry picked from commit 7c82a7a8f3a66f47f727d31691d6298d88ed158b)


  Commit: 0f0634bc8cf8a6d82a2110a6e983cf92032115c9
      https://github.com/openssl/openssl/commit/0f0634bc8cf8a6d82a2110a6e983cf92032115c9
  Author: Matt Caswell <matt at openssl.org>
  Date:   2022-08-17 (Wed, 17 Aug 2022)

  Changed paths:
    M .github/workflows/ci.yml

  Log Message:
  -----------
  Ensure we build ub sanitizer builds with -DPEDANTIC

Otherwise we may get spurious results from ub sanitizer. For example we
assume we can tolerate some unaligned write without this define that ub
sanitizer will complain about.

Reviewed-by: Dmitry Belyavskiy <beldmit at gmail.com>
Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Hugo Landau <hlandau at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18983)

(cherry picked from commit 17b94de3df327e6619e52529e345a340d4a0a100)


Compare: https://github.com/openssl/openssl/compare/d4b9a613839c...0f0634bc8cf8


More information about the openssl-commits mailing list