[openssl/openssl] 2ce940: Cast values to match printf format strings.

jwt27 noreply at github.com
Thu Dec 8 00:12:05 UTC 2022


  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: 2ce940e54e9a1bbe1d99aa655567c91d715f74ab
      https://github.com/openssl/openssl/commit/2ce940e54e9a1bbe1d99aa655567c91d715f74ab
  Author: J.W. Jagersma <jwjagersma at gmail.com>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M crypto/asn1/x_int64.c
    M ssl/ssl_ciph.c
    M ssl/ssl_txt.c
    M ssl/t1_trce.c
    M test/ssl_cert_table_internal_test.c

  Log Message:
  -----------
  Cast values to match printf format strings.

For some reason djgpp uses '(unsigned) long int' for (u)int32_t.  This
causes errors with -Werror=format, even though these types are in
practice identical.

Obvious solution: cast to the types indicated by the format string.

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19843)


  Commit: f7ff0d34f29a59a91e768f42971c8ade4801302e
      https://github.com/openssl/openssl/commit/f7ff0d34f29a59a91e768f42971c8ade4801302e
  Author: J.W. Jagersma <jwjagersma at gmail.com>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M crypto/bio/bss_dgram.c

  Log Message:
  -----------
  Cast socklen_t to size_t in assert comparison

This causes a warning otherwise when socklen_t is signed (Watt32).

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19843)


  Commit: 2a2100329839699b915432cfb1e8276b6ccb26bc
      https://github.com/openssl/openssl/commit/2a2100329839699b915432cfb1e8276b6ccb26bc
  Author: J.W. Jagersma <jwjagersma at gmail.com>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M crypto/threads_lib.c

  Log Message:
  -----------
  Define threads_lib.c functions only for OPENSSL_SYS_UNIX

This matches the declaration in <openssl/crypto.h>.

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19843)


  Commit: afec90df259be3002dfc605593f6e31b194f37b6
      https://github.com/openssl/openssl/commit/afec90df259be3002dfc605593f6e31b194f37b6
  Author: J.W. Jagersma <jwjagersma at gmail.com>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M ssl/ssl_sess.c
    M ssl/statem/extensions_srvr.c

  Log Message:
  -----------
  Fix warnings with unsigned time_t

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19843)


  Commit: 25b0b21722021573615b2d7d61786f3573334c7d
      https://github.com/openssl/openssl/commit/25b0b21722021573615b2d7d61786f3573334c7d
  Author: J.W. Jagersma <jwjagersma at gmail.com>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M crypto/bio/bss_dgram.c

  Log Message:
  -----------
  djgpp: Fix unused-but-set-variable warning

I chose to just hide this behind '#ifndef __DJGPP__', instead of listing
all the macro combinations where it *is* used.  That would make quite a
mess.

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19843)


Compare: https://github.com/openssl/openssl/compare/f3e9308fe1b6...25b0b2172202


More information about the openssl-commits mailing list