[openssl/openssl] 93d9d6: cmp_http.c: extend comment in keep_alive()

David von Oheimb noreply at reply.github.openssl.org
Mon Jul 11 09:06:05 UTC 2022


  Branch: refs/heads/master
  Home:   https://github.openssl.org/openssl/openssl
  Commit: 93d9d6097685dc29e654db15c091c550aef16d5b
      https://github.openssl.org/openssl/openssl/commit/93d9d6097685dc29e654db15c091c550aef16d5b
  Author: Dr. David von Oheimb <David.von.Oheimb at siemens.com>
  Date:   2022-07-11 (Mon, 11 Jul 2022)

  Changed paths:
    M crypto/cmp/cmp_http.c

  Log Message:
  -----------
  cmp_http.c: extend comment in keep_alive()

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb at siemens.com>
(Merged from https://github.com/openssl/openssl/pull/18702)


  Commit: 8c094747d78bb8627e9ca5241fed0550a3de2fdb
      https://github.openssl.org/openssl/openssl/commit/8c094747d78bb8627e9ca5241fed0550a3de2fdb
  Author: Dr. David von Oheimb <David.von.Oheimb at siemens.com>
  Date:   2022-07-11 (Mon, 11 Jul 2022)

  Changed paths:
    M apps/cmp.c

  Log Message:
  -----------
  apps/cmp.c: fix cleanup of CMP_CTX vs. APP_HTTP_TLS_INFO in its http_cb_arg field

Prevent crashes on error by making sure the info is freed after OSSL_CMP_CTX_free(),
which may call OSSL_HTTP_close() and thus indirectly reference the info.
Moreover, should not attempt to reference the cmp_ctx variable when NULL.

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb at siemens.com>
(Merged from https://github.com/openssl/openssl/pull/18702)


Compare: https://github.openssl.org/openssl/openssl/compare/4798e0680b11...8c094747d78b


More information about the openssl-commits mailing list