[openssl/openssl] 54a84f: Don't try to make configuration leaner

Richard Levitte noreply at github.com
Sun Jul 24 02:15:33 UTC 2022


  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 54a84f02998b72fa63cd5309d915e43cfd85a06b
      https://github.com/openssl/openssl/commit/54a84f02998b72fa63cd5309d915e43cfd85a06b
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2022-07-24 (Sun, 24 Jul 2022)

  Changed paths:
    M Configure

  Log Message:
  -----------
  Don't try to make configuration leaner

This partially reverts Github PR #16378:
commit 764cf5b26306a8712e8b3d41599c44dc5ed07a25, titled "Configuration:
only produce a new configdata.pm if it has changed contents"

Unfortunately, the attempt to make configuration leaner didn't take
into account all the files that may or may not affect the outcome of
`configdata.pm`, and most of all, didn't take into account that `Makefile`
has clauses of its own to determined when a reconfiguration is needed, all
based on time stamps.

Something as simple as a changed `Configurations/10-main.conf`, where the
change doesn't affect the resulting `configdata.pm` gets `make` into a
reconfiguration loop, because `configdata.pm` is older than `10-main.conf`.

The lesson to remember is not to try to outsmart `make` in cases like this.

We retain the other parts of the PR mentioned, as they are still valid.

needed to be taken into account (all the Configurations/*.conf
as well as all the build.info)

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Todd Short <todd.short at me.com>
(Merged from https://github.com/openssl/openssl/pull/18832)




More information about the openssl-commits mailing list