[openssl/openssl] 30532e: Fix range_should_be_prefix() to actually return th...

matt noreply at reply.github.openssl.org
Tue Jun 28 15:16:36 UTC 2022

  Branch: refs/heads/master
  Home:   https://github.openssl.org/openssl/openssl
  Commit: 30532e59f475e0066c030693e4d614311a9e0cae
  Author: Matt Caswell <matt at openssl.org>
  Date:   2022-06-28 (Tue, 28 Jun 2022)

  Changed paths:
    M crypto/x509/v3_addr.c
    M test/v3ext.c

  Log Message:
  Fix range_should_be_prefix() to actually return the correct result

range_should_be_prefix() was misidentifying whether an IP address range
should in fact be represented as a prefix. This was due to a bug introduced
in commit 42d7d7dd which made this incorrect change:

-    OPENSSL_assert(memcmp(min, max, length) <= 0);
+    if (memcmp(min, max, length) <= 0)
+        return -1;

This error leads to incorrect DER being encoded/accepted.

Reported by Theo Buehler (@botovq)

Reviewed-by: Paul Dale <pauli at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18524)

More information about the openssl-commits mailing list