[openssl/openssl] 7d7801: Configuration: only produce a new configdata.pm if...

Richard Levitte noreply at reply.github.openssl.org
Sun May 22 15:45:44 UTC 2022


  Branch: refs/heads/openssl-3.0
  Home:   https://github.openssl.org/openssl/openssl
  Commit: 7d78017bd88758cc4cc1337da282f5439c17719a
      https://github.openssl.org/openssl/openssl/commit/7d78017bd88758cc4cc1337da282f5439c17719a
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2022-05-22 (Sun, 22 May 2022)

  Changed paths:
    M Configure
    M configdata.pm.in

  Log Message:
  -----------
  Configuration: only produce a new configdata.pm if it has changed contents

The goal is to avoid having too much of the OpenSSL source rebuilt
because configdata.pm got a new time stamp.  The conditions for
updating configdata.pm are now:

1.  its time stamp is older than Configure's, or...
2.  its contents has changed.

Fixes #16377

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Todd Short <todd.short at me.com>
(Merged from https://github.com/openssl/openssl/pull/16378)

(cherry picked from commit 764cf5b26306a8712e8b3d41599c44dc5ed07a25)


  Commit: 5cbd580be9012edb39a60dc303f9ea55c7e4d7bd
      https://github.openssl.org/openssl/openssl/commit/5cbd580be9012edb39a60dc303f9ea55c7e4d7bd
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2022-05-22 (Sun, 22 May 2022)

  Changed paths:
    M Configure
    M build.info
    M configdata.pm.in

  Log Message:
  -----------
  Configuration: produce include/openssl/configuration.h when configuring

The goal is to avoid having too much of the OpenSSL source rebuilt
because include/openssl/configuration.h, or even because it was a
Makefile target that was called upon (some make implementations
consider the use of a target as an update of that target, even if it
wasn't really updated).

To resolve this, we move the production of include/openssl/configuration.h
to configdata.pm, and only update it if there were any actual changes.

Fixes #16377

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Todd Short <todd.short at me.com>
(Merged from https://github.com/openssl/openssl/pull/16378)

(cherry picked from commit 2522889620446f1e56338367d1b6b028ea952bb4)


  Commit: ff3e71b33c3f0f2da189b102afe13e074c85646a
      https://github.openssl.org/openssl/openssl/commit/ff3e71b33c3f0f2da189b102afe13e074c85646a
  Author: Richard Levitte <levitte at openssl.org>
  Date:   2022-05-22 (Sun, 22 May 2022)

  Changed paths:
    M Configurations/gentemplate.pm
    M Configure
    M build.info

  Log Message:
  -----------
  Building: For the FIPS module checksum, keep track of configuration,h

The FIPS module checksum needs to know that configuration.h is
generated from configuration.h.in, so that information is conserved.
To make this possible, it's now possible to have attributes with the
GENERATE keyword, and the attribute "skip" is added to make a keyword
a no-op, which makes it informative only.

Reviewed-by: Tomas Mraz <tomas at openssl.org>
Reviewed-by: Todd Short <todd.short at me.com>
(Merged from https://github.com/openssl/openssl/pull/16378)

(cherry picked from commit 4d02d500aac80c136e3d6582b908e0fab77bbf42)


Compare: https://github.openssl.org/openssl/openssl/compare/fa229d4e0726...ff3e71b33c3f


More information about the openssl-commits mailing list