[openssl/openssl] f471f6: Remove remaining refs to enc_(write|read)_ctx/(rea...

Mon Nov 14 07:56:00 UTC 2022

  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: f471f60a8adcbb72314be974f6bc320943786b96
      https://github.com/openssl/openssl/commit/f471f60a8adcbb72314be974f6bc320943786b96
  Author: Matt Caswell <matt at openssl.org>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M ssl/record/rec_layer_d1.c
    M ssl/record/rec_layer_s3.c
    M ssl/ssl_lib.c
    M ssl/ssl_local.h
    M ssl/statem/statem_clnt.c

  Log Message:
  -----------
  Remove remaining refs to enc_(write|read)_ctx/(read|write)_hash

Those fields are no longer used. Their previous function is now in the new
record layer.

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19586)

  Commit: 6d814fd6074b5f293abc3f19a190d3e34c426b6a
      https://github.com/openssl/openssl/commit/6d814fd6074b5f293abc3f19a190d3e34c426b6a
  Author: Matt Caswell <matt at openssl.org>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M ssl/ssl_lib.c
    M ssl/ssl_local.h

  Log Message:
  -----------
  Remove compress/expand fields from SSL_CONNECTION

They are no longer needed. The new record layer handles this.

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19586)

  Commit: b83eac48ed44afecd0d392c2fa055d345578078d
      https://github.com/openssl/openssl/commit/b83eac48ed44afecd0d392c2fa055d345578078d
  Author: Matt Caswell <matt at openssl.org>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M ssl/ssl_local.h
    M ssl/tls13_enc.c

  Log Message:
  -----------
  Remove the read_iv/write_iv fields from SSL_CONNECTION

These fields are instead held in the new record layer code and are
therefore no longer needed.

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19586)

  Commit: 1e42708e175f1453bd12f4632fbc0c61bade4e81
      https://github.com/openssl/openssl/commit/1e42708e175f1453bd12f4632fbc0c61bade4e81
  Author: Matt Caswell <matt at openssl.org>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M ssl/ssl_local.h
    M ssl/statem/statem_dtls.c

  Log Message:
  -----------
  Remove references to read_mac_secret and write_mac_secret

They are no longer used and can be removed.

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19586)

  Commit: c89c21f8f59d4973b7ccda6d6aaa2756636e2121
      https://github.com/openssl/openssl/commit/c89c21f8f59d4973b7ccda6d6aaa2756636e2121
  Author: Matt Caswell <matt at openssl.org>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M ssl/record/build.info
    M ssl/record/methods/build.info
    A ssl/record/methods/tls_pad.c
    R ssl/record/tls_pad.c

  Log Message:
  -----------
  Move tls_pad.c into ssl/record/methods

This file is used by libssl record layer methods and therefore should now
be in the methods subdir

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19586)

  Commit: 23c57f001d997b939f9b7c76ffbf9e81a16b0141
      https://github.com/openssl/openssl/commit/23c57f001d997b939f9b7c76ffbf9e81a16b0141
  Author: Matt Caswell <matt at openssl.org>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M ssl/record/build.info
    M ssl/record/methods/recmethod_local.h
    M ssl/record/methods/tls_common.c
    M ssl/record/methods/tlsany_meth.c
    M ssl/record/rec_layer_d1.c
    M ssl/record/rec_layer_s3.c
    M ssl/record/record.h
    M ssl/record/record_local.h
    R ssl/record/ssl3_record.c

  Log Message:
  -----------
  Move declarations out of record.h and record_local.h

We move many of the declarations in record.h and record_local.h into
locations inside ssl/record/methods instead. Also many declarations were
no longer required and could be removed completely.

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19586)

  Commit: e9189cc4af045523f91b2d9265add1ab1326fcdf
      https://github.com/openssl/openssl/commit/e9189cc4af045523f91b2d9265add1ab1326fcdf
  Author: Matt Caswell <matt at openssl.org>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M ssl/record/methods/dtls_meth.c
    M ssl/record/methods/ktls_meth.c
    M ssl/record/methods/recmethod_local.h
    M ssl/record/methods/tls1_meth.c
    M ssl/record/methods/tls_common.c
    M ssl/record/methods/tls_multib.c
    M util/indent.pro

  Log Message:
  -----------
  Rename SSL3_BUFFER to TLS_BUFFER

The SSL3 prefix no longer seems appropriate.

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19586)

  Commit: 22094d11a780f7485f0929ccfac806e0d02f82a9
      https://github.com/openssl/openssl/commit/22094d11a780f7485f0929ccfac806e0d02f82a9
  Author: Matt Caswell <matt at openssl.org>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M ssl/record/methods/dtls_meth.c
    M ssl/record/methods/ktls_meth.c
    M ssl/record/methods/recmethod_local.h
    M ssl/record/methods/ssl3_meth.c
    M ssl/record/methods/tls13_meth.c
    M ssl/record/methods/tls1_meth.c
    M ssl/record/methods/tls_common.c
    M ssl/record/methods/tlsany_meth.c
    M test/tls13encryptiontest.c
    M util/indent.pro

  Log Message:
  -----------
  Rename SSL3_RECORD to TLS_RL_RECORD

The SSL3 prefix no longer seems appropriate. We choose TLS_RL_RECORD instead
of TLS_RECORD because that type already exists elsewhere.

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19586)

  Commit: 20c7febc860ae8e67f52912ee205d2e324e7beed
      https://github.com/openssl/openssl/commit/20c7febc860ae8e67f52912ee205d2e324e7beed
  Author: Matt Caswell <matt at openssl.org>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M ssl/record/methods/dtls_meth.c
    M ssl/record/rec_layer_s3.c

  Log Message:
  -----------
  Fix memory leak when freeing the DTLS record layer

We need to check whether the sent_messages has actually buffered any
messages in it. If not we won't free the old record layer later when we
clear out the old buffered messages and a memory leak will result.

Reviewed-by: Hugo Landau <hlandau at openssl.org>
Reviewed-by: Tomas Mraz <tomas at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19586)

Compare: https://github.com/openssl/openssl/compare/1e065a151195...20c7febc860a