[openssl/openssl] 367ee2: stack: Do not add error if pop/shift/value accesse...

[Tomáš Mráz]

  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: 367ee2152e019d72f63537ae898eda311bc9219a
      https://github.com/openssl/openssl/commit/367ee2152e019d72f63537ae898eda311bc9219a
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2022-10-21 (Fri, 21 Oct 2022)

  Changed paths:
    M crypto/conf/conf_def.c
    M crypto/stack/stack.c
    M ssl/ssl_lib.c
    M ssl/statem/statem_srvr.c
    M test/helpers/ssltestlib.c

  Log Message:
  -----------
  stack: Do not add error if pop/shift/value accesses outside of the stack

This partially reverts commit 30eba7f35983a917f1007bce45040c0af3442e42.
This is legitimate use of the stack functions and no error
should be reported apart from the NULL return value.

Fixes #19389

Reviewed-by: Todd Short <todd.short at me.com>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19400)

(cherry picked from commit a8086e6bfc37355626393751a94bc5c92df7e9d3)


  Commit: b20d44eac8f0af4ecd7038f4c6b16c55eb794d0f
      https://github.com/openssl/openssl/commit/b20d44eac8f0af4ecd7038f4c6b16c55eb794d0f
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2022-10-21 (Fri, 21 Oct 2022)

  Changed paths:
    M doc/man3/DEFINE_STACK_OF.pod

  Log Message:
  -----------
  Document the stack functions that are forgiving

I.e., those that can be called with NULL stack parameter or invalid index.

Reviewed-by: Todd Short <todd.short at me.com>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19400)

(cherry picked from commit 0778364f8ec1f9702e62e6298aaa212ec40b6111)


  Commit: 6c366417f74e0c74256c102601efdced2b62829b
      https://github.com/openssl/openssl/commit/6c366417f74e0c74256c102601efdced2b62829b
  Author: Tomas Mraz <tomas at openssl.org>
  Date:   2022-10-21 (Fri, 21 Oct 2022)

  Changed paths:
    M crypto/stack/stack.c

  Log Message:
  -----------
  Errors raised from OPENSSL_sk_set should have ERR_LIB_CRYPTO

Reviewed-by: Todd Short <todd.short at me.com>
Reviewed-by: Paul Dale <pauli at openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19400)

(cherry picked from commit 3a09dfb4f9aace93d2c20d6d1b4968cc583884d6)


Compare: https://github.com/openssl/openssl/compare/d8f0b0fc1fe5...6c366417f74e